Re: [Qemu-devel] [PATCH 1/2] trace: Add "cpu_init" event

2016-09-15 Thread Lluís Vilanova
Stefan Hajnoczi writes: > On Thu, Sep 15, 2016 at 02:51:59PM +0200, Lluís Vilanova wrote: >> Stefan Hajnoczi writes: >> >> > On Wed, Sep 14, 2016 at 06:01:17PM +0200, Lluís Vilanova wrote: >> >> Stefan Hajnoczi writes: >> >> >> >> > On Tue, Sep 06, 2016 at 04:25:53PM +0200, Lluís Vilanova wrote:

Re: [Qemu-devel] [PATCH 1/2] trace: Add "cpu_init" event

2016-09-15 Thread Stefan Hajnoczi
On Thu, Sep 15, 2016 at 02:51:59PM +0200, Lluís Vilanova wrote: > Stefan Hajnoczi writes: > > > On Wed, Sep 14, 2016 at 06:01:17PM +0200, Lluís Vilanova wrote: > >> Stefan Hajnoczi writes: > >> > >> > On Tue, Sep 06, 2016 at 04:25:53PM +0200, Lluís Vilanova wrote: > >> >> +## vCPU > >> >> + > >>

Re: [Qemu-devel] [PATCH 1/2] trace: Add "cpu_init" event

2016-09-15 Thread Lluís Vilanova
Stefan Hajnoczi writes: > On Wed, Sep 14, 2016 at 06:01:17PM +0200, Lluís Vilanova wrote: >> Stefan Hajnoczi writes: >> >> > On Tue, Sep 06, 2016 at 04:25:53PM +0200, Lluís Vilanova wrote: >> >> +## vCPU >> >> + >> >> +# Create a new virtual (guest) CPU >> >> +# >> >> +# Targets: all >> >> +guest

Re: [Qemu-devel] [PATCH 1/2] trace: Add "cpu_init" event

2016-09-15 Thread Stefan Hajnoczi
On Wed, Sep 14, 2016 at 06:01:17PM +0200, Lluís Vilanova wrote: > Stefan Hajnoczi writes: > > > On Tue, Sep 06, 2016 at 04:25:53PM +0200, Lluís Vilanova wrote: > >> +## vCPU > >> + > >> +# Create a new virtual (guest) CPU > >> +# > >> +# Targets: all > >> +guest_cpu_init(void *cpu) "cpu=%p" > > >

Re: [Qemu-devel] [PATCH 1/2] trace: Add "cpu_init" event

2016-09-14 Thread Lluís Vilanova
Stefan Hajnoczi writes: > On Tue, Sep 06, 2016 at 04:25:53PM +0200, Lluís Vilanova wrote: >> +## vCPU >> + >> +# Create a new virtual (guest) CPU >> +# >> +# Targets: all >> +guest_cpu_init(void *cpu) "cpu=%p" > This isn't a vcpu trace event. Please add keep it with the other > non-vcpu trace ev

Re: [Qemu-devel] [PATCH 1/2] trace: Add "cpu_init" event

2016-09-14 Thread Stefan Hajnoczi
On Tue, Sep 06, 2016 at 04:25:53PM +0200, Lluís Vilanova wrote: > +## vCPU > + > +# Create a new virtual (guest) CPU > +# > +# Targets: all > +guest_cpu_init(void *cpu) "cpu=%p" This isn't a vcpu trace event. Please add keep it with the other non-vcpu trace events: # cpus.c guest_cpu_init(void *

[Qemu-devel] [PATCH 1/2] trace: Add "cpu_init" event

2016-09-06 Thread Lluís Vilanova
Signals the creation of a new virtual (guest) CPU. The event does not have the "vcpu" property because the machine creates its initial vCPUs before late trace state initialization, making the event "invisible" at system boot. Signed-off-by: Lluís Vilanova --- cpus.c |2 ++ stubs/cpus.