Re: [Qemu-devel] [PATCH 1/2] target-arm: Split DISAS_YIELD from DISAS_WFE

2015-06-28 Thread Peter Maydell
On 27 June 2015 at 03:25, Peter Crosthwaite wrote: > On Mon, Jun 15, 2015 at 11:49 AM, Peter Maydell > wrote: >> Currently we use DISAS_WFE for both WFE and YIELD instructions. >> This is functionally correct because at the moment both of them >> are implemented as "yield this CPU back to the top

Re: [Qemu-devel] [PATCH 1/2] target-arm: Split DISAS_YIELD from DISAS_WFE

2015-06-26 Thread Peter Crosthwaite
On Mon, Jun 15, 2015 at 11:49 AM, Peter Maydell wrote: > Currently we use DISAS_WFE for both WFE and YIELD instructions. > This is functionally correct because at the moment both of them > are implemented as "yield this CPU back to the top level loop so > another CPU has a chance to run". However

Re: [Qemu-devel] [PATCH 1/2] target-arm: Split DISAS_YIELD from DISAS_WFE

2015-06-26 Thread Andreas Färber
Am 15.06.2015 um 20:49 schrieb Peter Maydell: > diff --git a/target-arm/op_helper.c b/target-arm/op_helper.c > index 7fa32c4..5f06ca0 100644 > --- a/target-arm/op_helper.c > +++ b/target-arm/op_helper.c > @@ -334,6 +334,18 @@ void HELPER(wfe)(CPUARMState *env) > cpu_loop_exit(cs); > } > > +

[Qemu-devel] [PATCH 1/2] target-arm: Split DISAS_YIELD from DISAS_WFE

2015-06-15 Thread Peter Maydell
Currently we use DISAS_WFE for both WFE and YIELD instructions. This is functionally correct because at the moment both of them are implemented as "yield this CPU back to the top level loop so another CPU has a chance to run". However it's rather confusing that YIELD ends up calling HELPER(wfe), an