Re: [Qemu-devel] [PATCH 1/2] sphinx: add qmp_lexer

2019-05-22 Thread Peter Maydell
On Wed, 22 May 2019 at 20:02, John Snow wrote: > > > > On 5/22/19 4:49 AM, Peter Maydell wrote: > > On Tue, 21 May 2019 at 21:07, John Snow wrote: > >> > >> Sphinx, through Pygments, does not like annotated json examples very > >> much. In some versions of Sphinx (1.7), it will render the non-jso

Re: [Qemu-devel] [PATCH 1/2] sphinx: add qmp_lexer

2019-05-22 Thread John Snow
On 5/22/19 4:49 AM, Peter Maydell wrote: > On Tue, 21 May 2019 at 21:07, John Snow wrote: >> >> Sphinx, through Pygments, does not like annotated json examples very >> much. In some versions of Sphinx (1.7), it will render the non-json >> portions of code blocks in red, but in newer versions (2

Re: [Qemu-devel] [PATCH 1/2] sphinx: add qmp_lexer

2019-05-22 Thread Eduardo Habkost
On Wed, May 22, 2019 at 09:49:27AM +0100, Peter Maydell wrote: > On Tue, 21 May 2019 at 21:07, John Snow wrote: > > > > Sphinx, through Pygments, does not like annotated json examples very > > much. In some versions of Sphinx (1.7), it will render the non-json > > portions of code blocks in red, b

Re: [Qemu-devel] [PATCH 1/2] sphinx: add qmp_lexer

2019-05-22 Thread Peter Maydell
On Tue, 21 May 2019 at 21:07, John Snow wrote: > > Sphinx, through Pygments, does not like annotated json examples very > much. In some versions of Sphinx (1.7), it will render the non-json > portions of code blocks in red, but in newer versions (2.0) it will > throw an exception and not highlight

Re: [Qemu-devel] [PATCH 1/2] sphinx: add qmp_lexer

2019-05-21 Thread Eduardo Habkost
On Tue, May 21, 2019 at 04:06:56PM -0400, John Snow wrote: > Sphinx, through Pygments, does not like annotated json examples very > much. In some versions of Sphinx (1.7), it will render the non-json > portions of code blocks in red, but in newer versions (2.0) it will > throw an exception and not

[Qemu-devel] [PATCH 1/2] sphinx: add qmp_lexer

2019-05-21 Thread John Snow
Sphinx, through Pygments, does not like annotated json examples very much. In some versions of Sphinx (1.7), it will render the non-json portions of code blocks in red, but in newer versions (2.0) it will throw an exception and not highlight the block at all. Though we can suppress this warning, it