Re: [Qemu-devel] [PATCH 1/2] sched: add virt sched domain for the guest

2012-05-23 Thread Dave Hansen
On 05/23/2012 01:48 AM, Peter Zijlstra wrote: > On Wed, 2012-05-23 at 16:34 +0800, Liu ping fan wrote: >> > so we need to migrate some of vcpus from node-B to node-A, or to >> > node-C. > This is absolutely broken, you cannot do that. > > A guest task might want to be node affine, it looks at the

Re: [Qemu-devel] [PATCH 1/2] sched: add virt sched domain for the guest

2012-05-23 Thread Peter Zijlstra
On Wed, 2012-05-23 at 08:23 -0700, Dave Hansen wrote: > On 05/23/2012 01:48 AM, Peter Zijlstra wrote: > > On Wed, 2012-05-23 at 16:34 +0800, Liu ping fan wrote: > >> > so we need to migrate some of vcpus from node-B to node-A, or to > >> > node-C. > > This is absolutely broken, you cannot do that.

Re: [Qemu-devel] [PATCH 1/2] sched: add virt sched domain for the guest

2012-05-23 Thread Peter Zijlstra
On Wed, 2012-05-23 at 17:58 +0800, Liu ping fan wrote: > > Please go do something else, I'll do this. > OK so that was to say never, as in dynamic cpu:node relations aren't going to happen. but tip/sched/numa contain the bits needed to make vnuma work.

Re: [Qemu-devel] [PATCH 1/2] sched: add virt sched domain for the guest

2012-05-23 Thread Liu ping fan
On Wed, May 23, 2012 at 4:48 PM, Peter Zijlstra wrote: > On Wed, 2012-05-23 at 16:34 +0800, Liu ping fan wrote: >> so we need to migrate some of vcpus from node-B to node-A, or to >> node-C. > > This is absolutely broken, you cannot do that. > > A guest task might want to be node affine, it looks

Re: [Qemu-devel] [PATCH 1/2] sched: add virt sched domain for the guest

2012-05-23 Thread Peter Zijlstra
On Wed, 2012-05-23 at 16:10 +0800, Liu ping fan wrote: > the movement of vcpu > threads among host nodes will break the topology initialized by -numa > option. You want to remap vcpu to nodes? Are you bloody insane? cpu:node maps are assumed static, you cannot make that a dynamic map and pray thi

Re: [Qemu-devel] [PATCH 1/2] sched: add virt sched domain for the guest

2012-05-23 Thread Peter Zijlstra
On Wed, 2012-05-23 at 16:34 +0800, Liu ping fan wrote: > so we need to migrate some of vcpus from node-B to node-A, or to > node-C. This is absolutely broken, you cannot do that. A guest task might want to be node affine, it looks at the topology sets a cpu affinity mask and expects to stay on th

Re: [Qemu-devel] [PATCH 1/2] sched: add virt sched domain for the guest

2012-05-23 Thread Peter Zijlstra
On Wed, 2012-05-23 at 14:32 +0800, Liu Ping Fan wrote: > From: Liu Ping Fan > > The guest's scheduler can not see the numa info on the host and > this will result to the following scene: > Supposing vcpu-a on nodeA, vcpu-b on nodeB, when load balance, > the tasks' pull and push between these vc

Re: [Qemu-devel] [PATCH 1/2] sched: add virt sched domain for the guest

2012-05-23 Thread Liu ping fan
On Wed, May 23, 2012 at 4:23 PM, Peter Zijlstra wrote: > On Wed, 2012-05-23 at 16:10 +0800, Liu ping fan wrote: >> the movement of vcpu >> threads among host nodes will break the topology initialized by -numa >> option. > > You want to remap vcpu to nodes? Are you bloody insane? cpu:node maps > ar

Re: [Qemu-devel] [PATCH 1/2] sched: add virt sched domain for the guest

2012-05-23 Thread Liu ping fan
On Wed, May 23, 2012 at 3:54 PM, Peter Zijlstra wrote: > On Wed, 2012-05-23 at 14:32 +0800, Liu Ping Fan wrote: >> From: Liu Ping Fan >> >> The guest's scheduler can not see the numa info on the host and >> this will result to the following scene: >>   Supposing vcpu-a on nodeA, vcpu-b on nodeB,

[Qemu-devel] [PATCH 1/2] sched: add virt sched domain for the guest

2012-05-22 Thread Liu Ping Fan
From: Liu Ping Fan The guest's scheduler can not see the numa info on the host and this will result to the following scene: Supposing vcpu-a on nodeA, vcpu-b on nodeB, when load balance, the tasks' pull and push between these vcpus will cost more. But unfortunately, currently, the guest is just