> On Fri, Dec 04, 2015 at 11:52:07AM +0800, Liang Li wrote:
> > There are some flaws in qemu_put_compression_data, this patch tries to
> > fix it. Now it can be used by other code.
> >
> > Signed-off-by: Liang Li
> > ---
> > migration/qemu-file.c | 10 +-
> > 1 file changed, 9 insertions(
On Fri, Dec 04, 2015 at 11:52:07AM +0800, Liang Li wrote:
> There are some flaws in qemu_put_compression_data, this patch tries
> to fix it. Now it can be used by other code.
>
> Signed-off-by: Liang Li
> ---
> migration/qemu-file.c | 10 +-
> 1 file changed, 9 insertions(+), 1 deletion(
On Fri, Dec 04, 2015 at 11:52:07AM +0800, Liang Li wrote:
> There are some flaws in qemu_put_compression_data, this patch tries
> to fix it. Now it can be used by other code.
This commit description is vague and doesn't explain what this patch
does or why it is necessary.
Please try to cover "wha
> >> - blen could still be smaller that compressBound(size), you need to
> >> recheck
> >> - blen could have changed, but you don't take that in account for the
> >> following caller.
> >>
> >> So, I think code has a bug?
> >
> > Yes, there is a bug, I should consider the case QEMUFile with emp
"Li, Liang Z" wrote:
>> > There are some flaws in qemu_put_compression_data, this patch tries to
>> > fix it. Now it can be used by other code.
>> >
>> > Signed-off-by: Liang Li
>> > ---
>> > migration/qemu-file.c | 10 +-
>> > 1 file changed, 9 insertions(+), 1 deletion(-)
>> >
>> > dif
> On (Fri) 04 Dec 2015 [11:53:09], Liang Li wrote:
> > There are some flaws in qemu_put_compression_data, this patch tries to
> > fix it. Now it can be used by other code.
>
> Can you please write a better description here? What are the flaws?
> What is being fixed? What other users, and how is
> > There are some flaws in qemu_put_compression_data, this patch tries to
> > fix it. Now it can be used by other code.
> >
> > Signed-off-by: Liang Li
> > ---
> > migration/qemu-file.c | 10 +-
> > 1 file changed, 9 insertions(+), 1 deletion(-)
> >
> > diff --git a/migration/qemu-file.c
On (Fri) 04 Dec 2015 [11:53:09], Liang Li wrote:
> There are some flaws in qemu_put_compression_data, this patch tries
> to fix it. Now it can be used by other code.
Can you please write a better description here? What are the flaws?
What is being fixed? What other users, and how is it now safer
Liang Li wrote:
> There are some flaws in qemu_put_compression_data, this patch tries
> to fix it. Now it can be used by other code.
>
> Signed-off-by: Liang Li
> ---
> migration/qemu-file.c | 10 +-
> 1 file changed, 9 insertions(+), 1 deletion(-)
>
> diff --git a/migration/qemu-file.c
There are some flaws in qemu_put_compression_data, this patch tries
to fix it. Now it can be used by other code.
Signed-off-by: Liang Li
---
migration/qemu-file.c | 10 +-
1 file changed, 9 insertions(+), 1 deletion(-)
diff --git a/migration/qemu-file.c b/migration/qemu-file.c
index 0bb
There are some flaws in qemu_put_compression_data, this patch tries
to fix it. Now it can be used by other code.
Signed-off-by: Liang Li
---
migration/qemu-file.c | 10 +-
1 file changed, 9 insertions(+), 1 deletion(-)
diff --git a/migration/qemu-file.c b/migration/qemu-file.c
index 0bb
11 matches
Mail list logo
