Re: [Qemu-devel] [PATCH 1/2] qapi: add visitor for parsing int[KMGT] input string

2012-12-10 Thread Igor Mammedov
On Mon, 10 Dec 2012 11:27:46 -0600 mdroth wrote: > On Mon, Dec 10, 2012 at 05:01:38PM +0100, Igor Mammedov wrote: > > On Fri, 07 Dec 2012 19:57:35 +0100 > > Andreas Färber wrote: > > > > > Am 06.12.2012 22:12, schrieb Igor Mammedov: > > > > Caller of visit_type_unit_suffixed_int() will have to

Re: [Qemu-devel] [PATCH 1/2] qapi: add visitor for parsing int[KMGT] input string

2012-12-10 Thread mdroth
On Mon, Dec 10, 2012 at 05:01:38PM +0100, Igor Mammedov wrote: > On Fri, 07 Dec 2012 19:57:35 +0100 > Andreas Färber wrote: > > > Am 06.12.2012 22:12, schrieb Igor Mammedov: > > > Caller of visit_type_unit_suffixed_int() will have to specify > > > value of 'K' suffix via unit argument. > > > For

Re: [Qemu-devel] [PATCH 1/2] qapi: add visitor for parsing int[KMGT] input string

2012-12-10 Thread Igor Mammedov
On Fri, 07 Dec 2012 19:57:35 +0100 Andreas Färber wrote: > Am 06.12.2012 22:12, schrieb Igor Mammedov: > > Caller of visit_type_unit_suffixed_int() will have to specify > > value of 'K' suffix via unit argument. > > For Kbytes it's 1024, for Khz it's 1000. > > > > Signed-off-by: Igor Mammedov >

Re: [Qemu-devel] [PATCH 1/2] qapi: add visitor for parsing int[KMGT] input string

2012-12-07 Thread Eduardo Habkost
On Fri, Dec 07, 2012 at 07:57:35PM +0100, Andreas Färber wrote: [...] > > +static void parse_type_unit_suffixed_int(Visitor *v, int64_t *obj, > > + const char *name, const int unit, > > + Error **errp) > > +{ > > +S

Re: [Qemu-devel] [PATCH 1/2] qapi: add visitor for parsing int[KMGT] input string

2012-12-07 Thread Andreas Färber
Am 06.12.2012 22:12, schrieb Igor Mammedov: > Caller of visit_type_unit_suffixed_int() will have to specify > value of 'K' suffix via unit argument. > For Kbytes it's 1024, for Khz it's 1000. > > Signed-off-by: Igor Mammedov > --- > v2: > - convert type_freq to type_unit_suffixed_int. > - pr

Re: [Qemu-devel] [PATCH 1/2] qapi: add visitor for parsing int[KMGT] input string

2012-12-07 Thread Eduardo Habkost
On Thu, Dec 06, 2012 at 10:12:04PM +0100, Igor Mammedov wrote: > Caller of visit_type_unit_suffixed_int() will have to specify > value of 'K' suffix via unit argument. > For Kbytes it's 1024, for Khz it's 1000. > > Signed-off-by: Igor Mammedov > --- > v2: > - convert type_freq to type_unit_suf

Re: [Qemu-devel] [PATCH 1/2] qapi: add visitor for parsing int[KMGT] input string

2012-12-06 Thread mdroth
On Thu, Dec 06, 2012 at 10:12:04PM +0100, Igor Mammedov wrote: > Caller of visit_type_unit_suffixed_int() will have to specify > value of 'K' suffix via unit argument. > For Kbytes it's 1024, for Khz it's 1000. > > Signed-off-by: Igor Mammedov Reviewed-by: Michael Roth > --- > v2: > - conve

[Qemu-devel] [PATCH 1/2] qapi: add visitor for parsing int[KMGT] input string

2012-12-06 Thread Igor Mammedov
Caller of visit_type_unit_suffixed_int() will have to specify value of 'K' suffix via unit argument. For Kbytes it's 1024, for Khz it's 1000. Signed-off-by: Igor Mammedov --- v2: - convert type_freq to type_unit_suffixed_int. - provide qapi_dealloc_type_unit_suffixed_int() impl. --- qapi/qa