Re: [Qemu-devel] [PATCH 1/2] qapi: Add "detect-zeroes" option to drive-mirror

2015-06-10 Thread Andrey Korolyov
On Wed, Jun 10, 2015 at 7:04 PM, Alexandre DERUMIER wrote: >>>Sorry, forgot to mention - of course I`ve pulled all previous >>>zeroing-related queue, so I haven`t had only the QMP-related fix >>>running on top of the master :) > > Hi, I had a discussion about rbd mirroring, detect-zeroes and spars

Re: [Qemu-devel] [PATCH 1/2] qapi: Add "detect-zeroes" option to drive-mirror

2015-06-10 Thread Alexandre DERUMIER
" - Mail original - De: "Andrey Korolyov" À: "Fam Zheng" Cc: "Kevin Wolf" , "qemu block" , "Jeff Cody" , "qemu-devel" , "Markus Armbruster" , "stefanha" , "pbonzini" Envoyé: Mercredi 10

Re: [Qemu-devel] [PATCH 1/2] qapi: Add "detect-zeroes" option to drive-mirror

2015-06-10 Thread Andrey Korolyov
> '{"execute":"drive-mirror", "arguments": { "device": > "drive-virtio-disk0", "target": > "rbd:dev-rack2/vm33090-dest:id=qemukvm:key=xxx:auth_supported=cephx\\;none:mon_host=10.6.0.1\\:6789\\;10.6.0.3\\:6789\\;10.6.0.4\\:6789", > "mode": "existing", "sync": "full", "detect-zeroes": true, "format":

Re: [Qemu-devel] [PATCH 1/2] qapi: Add "detect-zeroes" option to drive-mirror

2015-06-10 Thread Andrey Korolyov
On Mon, Jun 8, 2015 at 10:06 AM, Fam Zheng wrote: > The new optional flag defaults to true, in which case, mirror job would > check the read sectors and use sparse write if they are zero. Otherwise > data will be fully copied. > > Signed-off-by: Fam Zheng > --- > block/mirror.c| 21

[Qemu-devel] [PATCH 1/2] qapi: Add "detect-zeroes" option to drive-mirror

2015-06-08 Thread Fam Zheng
The new optional flag defaults to true, in which case, mirror job would check the read sectors and use sparse write if they are zero. Otherwise data will be fully copied. Signed-off-by: Fam Zheng --- block/mirror.c| 21 +++-- blockdev.c| 6 +- hm