Re: [Qemu-devel] [PATCH 1/2] pc: fix regression introduced by adding 2.8 machine

2016-09-16 Thread Igor Mammedov
On Thu, 15 Sep 2016 18:18:46 +0300 "Michael S. Tsirkin" wrote: > On Thu, Sep 15, 2016 at 11:19:09AM -0300, Eduardo Habkost wrote: > > On Wed, Sep 14, 2016 at 12:01:49PM +0200, Igor Mammedov wrote: > > > commit (a4d3c834 pc: Add 2.8 machine) didn't ammend > > > PC_COMPAT_2_6 to include PC_COMPAT

Re: [Qemu-devel] [PATCH 1/2] pc: fix regression introduced by adding 2.8 machine

2016-09-15 Thread Michael S. Tsirkin
On Thu, Sep 15, 2016 at 11:19:09AM -0300, Eduardo Habkost wrote: > On Wed, Sep 14, 2016 at 12:01:49PM +0200, Igor Mammedov wrote: > > commit (a4d3c834 pc: Add 2.8 machine) didn't ammend > > PC_COMPAT_2_6 to include PC_COMPAT_2_7 which results in > > > > {\ > > .driver = "virtio-pci",

Re: [Qemu-devel] [PATCH 1/2] pc: fix regression introduced by adding 2.8 machine

2016-09-15 Thread Eduardo Habkost
On Wed, Sep 14, 2016 at 12:01:49PM +0200, Igor Mammedov wrote: > commit (a4d3c834 pc: Add 2.8 machine) didn't ammend > PC_COMPAT_2_6 to include PC_COMPAT_2_7 which results in > > {\ > .driver = "virtio-pci",\ > .property = "page-per-vq",\ > .value= "on",\ > },

Re: [Qemu-devel] [PATCH 1/2] pc: fix regression introduced by adding 2.8 machine

2016-09-14 Thread Marcel Apfelbaum
On 09/14/2016 01:01 PM, Igor Mammedov wrote: commit (a4d3c834 pc: Add 2.8 machine) didn't ammend PC_COMPAT_2_6 to include PC_COMPAT_2_7 which results in {\ .driver = "virtio-pci",\ .property = "page-per-vq",\ .value= "on",\ }, and {\ .driver

[Qemu-devel] [PATCH 1/2] pc: fix regression introduced by adding 2.8 machine

2016-09-14 Thread Igor Mammedov
commit (a4d3c834 pc: Add 2.8 machine) didn't ammend PC_COMPAT_2_6 to include PC_COMPAT_2_7 which results in {\ .driver = "virtio-pci",\ .property = "page-per-vq",\ .value= "on",\ }, and {\ .driver = TYPE_X86_CPU,\ .property = "l3-cache"