[Qemu-devel] [PATCH 1/2] nvme: fix identify to be NVMe 1.1 compliant

2016-08-04 Thread Christoph Hellwig
NVMe 1.1 requires devices to implement a Namespace List subcommand of the identify command. Qemu not only not implements this features, but also misinterprets it as an Identify Controller request. Due to this any OS trying to use the Namespace List will fail the probe. Signed-off-by: Christoph H

Re: [Qemu-devel] [PATCH 1/2] nvme: fix identify to be NVMe 1.1 compliant

2015-11-18 Thread Christoph Hellwig
Meh, this was still missing the uncommited changes for the nsid off by one vs the array index: diff --git a/hw/block/nvme.c b/hw/block/nvme.c index 360be71..4f768d5 100644 --- a/hw/block/nvme.c +++ b/hw/block/nvme.c @@ -499,10 +499,10 @@ static uint16_t nvme_identify_nslist(NvmeCtrl *n, NvmeIdent

[Qemu-devel] [PATCH 1/2] nvme: fix identify to be NVMe 1.1 compliant

2015-11-18 Thread Christoph Hellwig
NVMe 1.1 requires devices to implement a Namespace List subcommand of the identify command. Qemu not only not implements this features, but also misinterprets it as an Identify Controller request. Due to this any OS trying to use the Namespace List will fail the probe. Signed-off-by: Christoph H