Re: [Qemu-devel] [PATCH 1/2] migration: do cleanup operation after completion

2015-08-12 Thread Li, Liang Z
> > On 12/08/2015 23:04, Liang Li wrote: > > @@ -1008,8 +1009,10 @@ static void *migration_thread(void *opaque) > > } > > > > qemu_mutex_lock_iothread(); > > +end_time = qemu_clock_get_ms(QEMU_CLOCK_REALTIME); > > +qemu_savevm_state_cancel(); > > + > > You can remove the qemu_sa

Re: [Qemu-devel] [PATCH 1/2] migration: do cleanup operation after completion

2015-08-12 Thread Paolo Bonzini
On 12/08/2015 23:04, Liang Li wrote: > @@ -1008,8 +1009,10 @@ static void *migration_thread(void *opaque) > } > > qemu_mutex_lock_iothread(); > +end_time = qemu_clock_get_ms(QEMU_CLOCK_REALTIME); > +qemu_savevm_state_cancel(); > + You can remove the qemu_savevm_state_cancel()

[Qemu-devel] [PATCH 1/2] migration: do cleanup operation after completion

2015-08-12 Thread Liang Li
Because of the patch 3ea3b7fa9af067982f34b of kvm, now the migration_end() is a time consuming operation, which takes about dozens of milliseconds, and will prolong VM downtime. Such an operation should be done after migration completion. For a VM with 8G RAM, this patch can reduce the VM downtime