Re: [Qemu-devel] [PATCH 1/2] hw/usb-ohci: Honour endpoint maximum packet size

2011-09-15 Thread Gerd Hoffmann
On 09/15/11 13:24, Peter Maydell wrote: On 15 September 2011 11:49, Gerd Hoffmann wrote: Peter Maydell wrote: It seems to me that at least some of that is likely to be guest-visible, especially in the case where an endpoint returns an error partway through. So it's not clear to me that you cou

Re: [Qemu-devel] [PATCH 1/2] hw/usb-ohci: Honour endpoint maximum packet size

2011-09-15 Thread Peter Maydell
On 15 September 2011 11:49, Gerd Hoffmann wrote: >Peter Maydell wrote: >> It seems to me that at least some of that is likely to be >> guest-visible, especially in the case where an endpoint returns an >> error partway through. So it's not clear to me that you could >> validly batch up everything

Re: [Qemu-devel] [PATCH 1/2] hw/usb-ohci: Honour endpoint maximum packet size

2011-09-15 Thread Gerd Hoffmann
Hi, No. What I think is that USBPacket shouldn't be required to be an actual USB packet, but a transfer, i.e. do the splitting of larger transfers into smaller packets in the usb driver emulation (if needed), not the host adapter emulation. The OHCI spec still requires us to only process on

Re: [Qemu-devel] [PATCH 1/2] hw/usb-ohci: Honour endpoint maximum packet size

2011-09-15 Thread Peter Maydell
On 15 September 2011 10:13, Gerd Hoffmann wrote: > On 09/15/11 10:36, Peter Maydell wrote: >> >> On 15 September 2011 08:33, Gerd Hoffmann  wrote: >>> >>> On 09/14/11 19:48, Peter Maydell wrote: Honour the maximum packet size for endpoints; this applies when sending non-isochronous

Re: [Qemu-devel] [PATCH 1/2] hw/usb-ohci: Honour endpoint maximum packet size

2011-09-15 Thread Gerd Hoffmann
On 09/15/11 10:36, Peter Maydell wrote: On 15 September 2011 08:33, Gerd Hoffmann wrote: On 09/14/11 19:48, Peter Maydell wrote: Honour the maximum packet size for endpoints; this applies when sending non-isochronous data and means we transfer only as much as the endpoint allows, leaving the

Re: [Qemu-devel] [PATCH 1/2] hw/usb-ohci: Honour endpoint maximum packet size

2011-09-15 Thread Peter Maydell
On 15 September 2011 08:33, Gerd Hoffmann wrote: > On 09/14/11 19:48, Peter Maydell wrote: >> >> Honour the maximum packet size for endpoints; this applies when >> sending non-isochronous data and means we transfer only as >> much as the endpoint allows, leaving the transfer descriptor >> on the l

Re: [Qemu-devel] [PATCH 1/2] hw/usb-ohci: Honour endpoint maximum packet size

2011-09-15 Thread Gerd Hoffmann
On 09/14/11 19:48, Peter Maydell wrote: Honour the maximum packet size for endpoints; this applies when sending non-isochronous data and means we transfer only as much as the endpoint allows, leaving the transfer descriptor on the list for another go next time around. This allows usb-net to work

[Qemu-devel] [PATCH 1/2] hw/usb-ohci: Honour endpoint maximum packet size

2011-09-14 Thread Peter Maydell
Honour the maximum packet size for endpoints; this applies when sending non-isochronous data and means we transfer only as much as the endpoint allows, leaving the transfer descriptor on the list for another go next time around. This allows usb-net to work when connected to an OHCI controller model