Re: [Qemu-devel] [PATCH 1/2] hw/loader: Support ramdisk with u-boot header

2013-06-18 Thread Peter Crosthwaite
Hi Soren, On Sat, Jun 15, 2013 at 3:14 AM, Sören Brinkmann wrote: > Hi Peter, > > On Fri, Jun 14, 2013 at 05:56:31PM +0100, Peter Maydell wrote: >> On 14 June 2013 17:36, Soren Brinkmann wrote: >> > Introduce 'load_ramdisk()' which can load "normal" ramdisks and ramdisks >> > with a u-boot heade

Re: [Qemu-devel] [PATCH 1/2] hw/loader: Support ramdisk with u-boot header

2013-06-14 Thread Sören Brinkmann
On Fri, Jun 14, 2013 at 06:36:06PM +0100, Peter Maydell wrote: > On 14 June 2013 18:14, Sören Brinkmann wrote: > > On Fri, Jun 14, 2013 at 05:56:31PM +0100, Peter Maydell wrote: > >> If we're providing separate functions for kernel and > >> ramdisk loading shouldn't they check that the uimage > >>

Re: [Qemu-devel] [PATCH 1/2] hw/loader: Support ramdisk with u-boot header

2013-06-14 Thread Peter Maydell
On 14 June 2013 18:14, Sören Brinkmann wrote: > On Fri, Jun 14, 2013 at 05:56:31PM +0100, Peter Maydell wrote: >> If we're providing separate functions for kernel and >> ramdisk loading shouldn't they check that the uimage >> has the appropriate type? > I'm not sure I understand what you mean here

Re: [Qemu-devel] [PATCH 1/2] hw/loader: Support ramdisk with u-boot header

2013-06-14 Thread Sören Brinkmann
Hi Peter, On Fri, Jun 14, 2013 at 05:56:31PM +0100, Peter Maydell wrote: > On 14 June 2013 17:36, Soren Brinkmann wrote: > > Introduce 'load_ramdisk()' which can load "normal" ramdisks and ramdisks > > with a u-boot header. > > To enable this and leverage synergies 'load_uimage()' is refactored t

Re: [Qemu-devel] [PATCH 1/2] hw/loader: Support ramdisk with u-boot header

2013-06-14 Thread Peter Maydell
On 14 June 2013 17:36, Soren Brinkmann wrote: > Introduce 'load_ramdisk()' which can load "normal" ramdisks and ramdisks > with a u-boot header. > To enable this and leverage synergies 'load_uimage()' is refactored to > accomodate this additional use case. Hi; thanks for this patch; some review c

[Qemu-devel] [PATCH 1/2] hw/loader: Support ramdisk with u-boot header

2013-06-14 Thread Soren Brinkmann
Introduce 'load_ramdisk()' which can load "normal" ramdisks and ramdisks with a u-boot header. To enable this and leverage synergies 'load_uimage()' is refactored to accomodate this additional use case. Signed-off-by: Soren Brinkmann --- hw/core/loader.c| 86 +