On Wed, Aug 17, 2016 at 11:26:51AM +0200, Markus Armbruster wrote:
> Peter Xu writes:
>
> > On Tue, Aug 16, 2016 at 08:17:08PM +0800, Peter Xu wrote:
> >> > >
> >> > > Also, please make it a function, not a macro:
> >> > >
> >> > > void error_report_fatal(const char *fmt, ...)
> >> > >
Peter Xu writes:
> On Tue, Aug 16, 2016 at 08:17:08PM +0800, Peter Xu wrote:
>> > >
>> > > Also, please make it a function, not a macro:
>> > >
>> > > void error_report_fatal(const char *fmt, ...)
>> > > {
>> > > va_list ap;
>> > >
>> > > va_start(ap, fmt);
>> > >
On Tue, Aug 16, 2016 at 08:17:08PM +0800, Peter Xu wrote:
> > >
> > > Also, please make it a function, not a macro:
> > >
> > > void error_report_fatal(const char *fmt, ...)
> > > {
> > > va_list ap;
> > >
> > > va_start(ap, fmt);
> > > error_vreport(fmt, ap);
> >
On Wed, Aug 17, 2016 at 09:33:37AM +0200, Markus Armbruster wrote:
> > Yes I see usages for error_setg(&error_abort, ...), it makes sense to
> > provide error_report_abort() along with error_report_fatal(). Will
> > take your (and Fam's) advice.
>
> Recommend to make it a separate patch.
Will do.
Peter Xu writes:
> On Tue, Aug 16, 2016 at 04:45:13PM +0200, Markus Armbruster wrote:
>> Peter Xu writes:
>>
>> > On Tue, Aug 16, 2016 at 08:19:08PM +0800, Fam Zheng wrote:
>> >> On Tue, 08/16 20:17, Peter Xu wrote:
>> >> > > Do we really need error_report_exit when we already have error_fatal?
On Tue, Aug 16, 2016 at 04:45:13PM +0200, Markus Armbruster wrote:
> Peter Xu writes:
>
> > On Tue, Aug 16, 2016 at 08:19:08PM +0800, Fam Zheng wrote:
> >> On Tue, 08/16 20:17, Peter Xu wrote:
> >> > > Do we really need error_report_exit when we already have error_fatal?
> >> >
> >> > error_fata
Peter Xu writes:
> On Tue, Aug 16, 2016 at 08:19:08PM +0800, Fam Zheng wrote:
>> On Tue, 08/16 20:17, Peter Xu wrote:
>> > > Do we really need error_report_exit when we already have error_fatal?
>> >
>> > error_fatal is the name of a global var, not the function.
>>
>> I mean most error_report_
On Tue, 08/16 22:00, Peter Xu wrote:
> On Tue, Aug 16, 2016 at 08:19:08PM +0800, Fam Zheng wrote:
> > On Tue, 08/16 20:17, Peter Xu wrote:
> > > > Do we really need error_report_exit when we already have error_fatal?
> > >
> > > error_fatal is the name of a global var, not the function.
> >
> > I
On Tue, Aug 16, 2016 at 08:19:08PM +0800, Fam Zheng wrote:
> On Tue, 08/16 20:17, Peter Xu wrote:
> > > Do we really need error_report_exit when we already have error_fatal?
> >
> > error_fatal is the name of a global var, not the function.
>
> I mean most error_report_exit(...) calls can be conv
On Tue, 08/16 20:17, Peter Xu wrote:
> > Do we really need error_report_exit when we already have error_fatal?
>
> error_fatal is the name of a global var, not the function.
I mean most error_report_exit(...) calls can be converted to
error_setg(&error_fatal, ...).
Fam
On Tue, Aug 16, 2016 at 07:53:51PM +0800, Fam Zheng wrote:
> On Tue, 08/16 13:05, Markus Armbruster wrote:
> > Peter Xu writes:
> >
> > > There are many places in current QEMU codes that needs to print some
> > > error and then quit QEMU. Provide a macro for it.
> > >
> > > Also, one coccinelle s
On Tue, 08/16 13:05, Markus Armbruster wrote:
> Peter Xu writes:
>
> > There are many places in current QEMU codes that needs to print some
> > error and then quit QEMU. Provide a macro for it.
> >
> > Also, one coccinelle script is added to convert existing cases to
> > leverage this new macro.
Peter Xu writes:
> There are many places in current QEMU codes that needs to print some
> error and then quit QEMU. Provide a macro for it.
>
> Also, one coccinelle script is added to convert existing cases to
> leverage this new macro.
>
> Signed-off-by: Peter Xu
> ---
> include/qemu/error-rep
There are many places in current QEMU codes that needs to print some
error and then quit QEMU. Provide a macro for it.
Also, one coccinelle script is added to convert existing cases to
leverage this new macro.
Signed-off-by: Peter Xu
---
include/qemu/error-report.h| 8
14 matches
Mail list logo
