Re: [Qemu-devel] [PATCH 1/2] dataplane: move vring_more_avail() into vring.c

2015-01-21 Thread Greg Kurz
On Mon, 19 Jan 2015 17:04:36 + Stefan Hajnoczi wrote: > vring_more_avail() was an inline function in vring.h. No external > callers use it so it's not necessary to export it. > > Furthermore, we'll need virtio-access.h for endian-aware memory accesses > but that only works in per-target obj

Re: [Qemu-devel] [PATCH 1/2] dataplane: move vring_more_avail() into vring.c

2015-01-20 Thread David Gibson
On Mon, Jan 19, 2015 at 05:04:36PM +, Stefan Hajnoczi wrote: > vring_more_avail() was an inline function in vring.h. No external > callers use it so it's not necessary to export it. > > Furthermore, we'll need virtio-access.h for endian-aware memory accesses > but that only works in per-targe

[Qemu-devel] [PATCH 1/2] dataplane: move vring_more_avail() into vring.c

2015-01-19 Thread Stefan Hajnoczi
vring_more_avail() was an inline function in vring.h. No external callers use it so it's not necessary to export it. Furthermore, we'll need virtio-access.h for endian-aware memory accesses but that only works in per-target object files (obj-y) and not build-once object files (common-obj-y) like