Re: [Qemu-devel] [PATCH 1/2] commit: Add top-node/base-node options

2018-09-05 Thread Kevin Wolf
Am 05.09.2018 um 16:02 hat Peter Krempa geschrieben: > On Wed, Sep 05, 2018 at 08:48:15 -0500, Eric Blake wrote: > > On 09/05/2018 07:38 AM, Peter Krempa wrote: > > > > > block-commit is able to reopen the format layers and works as expected. > > > > > > Unfortunately though the 'read-only' optio

Re: [Qemu-devel] [PATCH 1/2] commit: Add top-node/base-node options

2018-09-05 Thread Peter Krempa
On Wed, Sep 05, 2018 at 08:48:15 -0500, Eric Blake wrote: > On 09/05/2018 07:38 AM, Peter Krempa wrote: > > > block-commit is able to reopen the format layers and works as expected. > > > > Unfortunately though the 'read-only' option is actually useful as the > > curl-driver does not work without

Re: [Qemu-devel] [PATCH 1/2] commit: Add top-node/base-node options

2018-09-05 Thread Eric Blake
On 09/05/2018 07:38 AM, Peter Krempa wrote: block-commit is able to reopen the format layers and works as expected. Unfortunately though the 'read-only' option is actually useful as the curl-driver does not work without it: -blockdev {"driver":"http","url":"http://ftp.sjtu.edu.cn:80/ubuntu-cd

Re: [Qemu-devel] [PATCH 1/2] commit: Add top-node/base-node options

2018-09-05 Thread Peter Krempa
On Tue, Sep 04, 2018 at 17:34:36 +0200, Kevin Wolf wrote: > Am 04.09.2018 um 17:00 hat Peter Krempa geschrieben: > > On Tue, Sep 04, 2018 at 16:42:17 +0200, Alberto Garcia wrote: > > > On Tue 04 Sep 2018 04:17:30 PM CEST, Peter Krempa wrote: [...] > > I remember being told some time ago to specif

Re: [Qemu-devel] [PATCH 1/2] commit: Add top-node/base-node options

2018-09-04 Thread Kevin Wolf
Am 04.09.2018 um 17:00 hat Peter Krempa geschrieben: > On Tue, Sep 04, 2018 at 16:42:17 +0200, Alberto Garcia wrote: > > On Tue 04 Sep 2018 04:17:30 PM CEST, Peter Krempa wrote: > > >> >> libvirt-3-format is read-write and all other node names are > > >> >> readonly in the above example. > > >> >>

Re: [Qemu-devel] [PATCH 1/2] commit: Add top-node/base-node options

2018-09-04 Thread Peter Krempa
On Tue, Sep 04, 2018 at 16:42:17 +0200, Alberto Garcia wrote: > On Tue 04 Sep 2018 04:17:30 PM CEST, Peter Krempa wrote: > >> >> libvirt-3-format is read-write and all other node names are > >> >> readonly in the above example. > >> >> > >> >> The same also happens when using filenames: > >> >> >

Re: [Qemu-devel] [PATCH 1/2] commit: Add top-node/base-node options

2018-09-04 Thread Alberto Garcia
On Tue 04 Sep 2018 04:17:30 PM CEST, Peter Krempa wrote: >> >> libvirt-3-format is read-write and all other node names are >> >> readonly in the above example. >> >> >> >> The same also happens when using filenames: >> >> >> >> {"execute":"block-commit", >> >> "arguments" : {"device":"libvirt-3-

Re: [Qemu-devel] [PATCH 1/2] commit: Add top-node/base-node options

2018-09-04 Thread Peter Krempa
On Mon, Sep 03, 2018 at 17:03:11 +0200, Kevin Wolf wrote: > Am 28.08.2018 um 16:26 hat Peter Krempa geschrieben: > > On Fri, Aug 10, 2018 at 18:26:57 +0200, Kevin Wolf wrote: > > > The block-commit QMP command required specifying the top and base nodes > > > of the commit jobs using the file name o

Re: [Qemu-devel] [PATCH 1/2] commit: Add top-node/base-node options

2018-09-04 Thread Peter Krempa
On Tue, Sep 04, 2018 at 15:13:44 +0200, Alberto Garcia wrote: > On Mon 03 Sep 2018 05:03:11 PM CEST, Kevin Wolf wrote: > >> libvirt-3-format is read-write and all other node names are readonly in > >> the above example. > >> > >> The same also happens when using filenames: > >> > >> {"execute":"b

Re: [Qemu-devel] [PATCH 1/2] commit: Add top-node/base-node options

2018-09-04 Thread Alberto Garcia
On Mon 03 Sep 2018 05:03:11 PM CEST, Kevin Wolf wrote: >> libvirt-3-format is read-write and all other node names are readonly in >> the above example. >> >> The same also happens when using filenames: >> >> {"execute":"block-commit", >> "arguments" : {"device":"libvirt-3-format", >>

Re: [Qemu-devel] [PATCH 1/2] commit: Add top-node/base-node options

2018-09-03 Thread Kevin Wolf
Am 28.08.2018 um 16:26 hat Peter Krempa geschrieben: > On Fri, Aug 10, 2018 at 18:26:57 +0200, Kevin Wolf wrote: > > The block-commit QMP command required specifying the top and base nodes > > of the commit jobs using the file name of that node. While this works > > in simple cases (local files wit

Re: [Qemu-devel] [PATCH 1/2] commit: Add top-node/base-node options

2018-08-28 Thread Peter Krempa
On Fri, Aug 10, 2018 at 18:26:57 +0200, Kevin Wolf wrote: > The block-commit QMP command required specifying the top and base nodes > of the commit jobs using the file name of that node. While this works > in simple cases (local files with absolute paths), the file names > generated for more compli

Re: [Qemu-devel] [PATCH 1/2] commit: Add top-node/base-node options

2018-08-13 Thread Max Reitz
On 2018-08-10 18:26, Kevin Wolf wrote: > The block-commit QMP command required specifying the top and base nodes > of the commit jobs using the file name of that node. While this works > in simple cases (local files with absolute paths), the file names > generated for more complicated setups can be

Re: [Qemu-devel] [PATCH 1/2] commit: Add top-node/base-node options

2018-08-13 Thread Eric Blake
On 08/13/2018 04:35 AM, Markus Armbruster wrote: Or, here's an idea: Keep the name @base and @top, but add a new '*by-node':'bool' parameter, defaulting to false for now, but perhaps with a deprecation warning that we'll switch the default to true in one release and delete the parameter altoget

Re: [Qemu-devel] [PATCH 1/2] commit: Add top-node/base-node options

2018-08-13 Thread Markus Armbruster
Kevin Wolf writes: > Am 10.08.2018 um 19:33 hat Eric Blake geschrieben: >> On 08/10/2018 11:26 AM, Kevin Wolf wrote: >> > The block-commit QMP command required specifying the top and base nodes >> > of the commit jobs using the file name of that node. While this works >> > in simple cases (local

Re: [Qemu-devel] [PATCH 1/2] commit: Add top-node/base-node options

2018-08-13 Thread Kevin Wolf
Am 10.08.2018 um 19:33 hat Eric Blake geschrieben: > On 08/10/2018 11:26 AM, Kevin Wolf wrote: > > The block-commit QMP command required specifying the top and base nodes > > of the commit jobs using the file name of that node. While this works > > in simple cases (local files with absolute paths),

Re: [Qemu-devel] [PATCH 1/2] commit: Add top-node/base-node options

2018-08-10 Thread Eric Blake
On 08/10/2018 11:26 AM, Kevin Wolf wrote: The block-commit QMP command required specifying the top and base nodes of the commit jobs using the file name of that node. While this works in simple cases (local files with absolute paths), the file names generated for more complicated setups can be ha

[Qemu-devel] [PATCH 1/2] commit: Add top-node/base-node options

2018-08-10 Thread Kevin Wolf
The block-commit QMP command required specifying the top and base nodes of the commit jobs using the file name of that node. While this works in simple cases (local files with absolute paths), the file names generated for more complicated setups can be hard to predict. This adds two new options to