Re: [Qemu-devel] [PATCH 1/2] block: remove QED .bdrv_make_empty implementation

2014-01-27 Thread Benoît Canet
Le Monday 27 Jan 2014 à 16:09:12 (-0500), Jeff Cody a écrit : > The QED .bdrv_make_empty() implementation does nothing but return > -ENOTSUP, which causes problems in bdrv_commit(). Since the function > stub exists for QED, it is called, which then always returns an error. > > The proper way to n

[Qemu-devel] [PATCH 1/2] block: remove QED .bdrv_make_empty implementation

2014-01-27 Thread Jeff Cody
The QED .bdrv_make_empty() implementation does nothing but return -ENOTSUP, which causes problems in bdrv_commit(). Since the function stub exists for QED, it is called, which then always returns an error. The proper way to not support an optional driver function stub is to just not implement it,