Re: [Qemu-devel] [PATCH 1/2] block: gluster - code movements, state storage changes

2014-02-14 Thread Kevin Wolf
Am 14.02.2014 um 15:41 hat Jeff Cody geschrieben: > On Fri, Feb 14, 2014 at 03:21:28PM +0100, Stefan Hajnoczi wrote: > > On Tue, Feb 04, 2014 at 02:26:58PM -0500, Jeff Cody wrote: > > > @@ -291,23 +311,17 @@ static int qemu_gluster_open(BlockDriverState *bs, > > > QDict *options, > > > > > >

Re: [Qemu-devel] [PATCH 1/2] block: gluster - code movements, state storage changes

2014-02-14 Thread Jeff Cody
On Fri, Feb 14, 2014 at 04:38:03PM +0100, Stefan Hajnoczi wrote: > On Fri, Feb 14, 2014 at 09:41:46AM -0500, Jeff Cody wrote: > > On Fri, Feb 14, 2014 at 03:21:28PM +0100, Stefan Hajnoczi wrote: > > > On Tue, Feb 04, 2014 at 02:26:58PM -0500, Jeff Cody wrote: > > > > @@ -291,23 +311,17 @@ static in

Re: [Qemu-devel] [PATCH 1/2] block: gluster - code movements, state storage changes

2014-02-14 Thread Stefan Hajnoczi
On Fri, Feb 14, 2014 at 09:41:46AM -0500, Jeff Cody wrote: > On Fri, Feb 14, 2014 at 03:21:28PM +0100, Stefan Hajnoczi wrote: > > On Tue, Feb 04, 2014 at 02:26:58PM -0500, Jeff Cody wrote: > > > @@ -291,23 +311,17 @@ static int qemu_gluster_open(BlockDriverState *bs, > > > QDict *options, > > >

Re: [Qemu-devel] [PATCH 1/2] block: gluster - code movements, state storage changes

2014-02-14 Thread Jeff Cody
On Fri, Feb 14, 2014 at 03:12:41PM +0100, Stefan Hajnoczi wrote: > On Tue, Feb 04, 2014 at 02:26:58PM -0500, Jeff Cody wrote: > > diff --git a/block/gluster.c b/block/gluster.c > > index a009b15..79af3fd 100644 > > --- a/block/gluster.c > > +++ b/block/gluster.c > > @@ -30,6 +30,8 @@ typedef struct

Re: [Qemu-devel] [PATCH 1/2] block: gluster - code movements, state storage changes

2014-02-14 Thread Jeff Cody
On Fri, Feb 14, 2014 at 03:21:28PM +0100, Stefan Hajnoczi wrote: > On Tue, Feb 04, 2014 at 02:26:58PM -0500, Jeff Cody wrote: > > @@ -291,23 +311,17 @@ static int qemu_gluster_open(BlockDriverState *bs, > > QDict *options, > > > > filename = qemu_opt_get(opts, "filename"); > > > > +s

Re: [Qemu-devel] [PATCH 1/2] block: gluster - code movements, state storage changes

2014-02-14 Thread Stefan Hajnoczi
On Tue, Feb 04, 2014 at 02:26:58PM -0500, Jeff Cody wrote: > @@ -291,23 +311,17 @@ static int qemu_gluster_open(BlockDriverState *bs, > QDict *options, > > filename = qemu_opt_get(opts, "filename"); > > +s->filename = g_strdup(filename); It's not obvious to me that copying the filen

Re: [Qemu-devel] [PATCH 1/2] block: gluster - code movements, state storage changes

2014-02-14 Thread Stefan Hajnoczi
On Tue, Feb 04, 2014 at 02:26:58PM -0500, Jeff Cody wrote: > diff --git a/block/gluster.c b/block/gluster.c > index a009b15..79af3fd 100644 > --- a/block/gluster.c > +++ b/block/gluster.c > @@ -30,6 +30,8 @@ typedef struct GlusterAIOCB { > typedef struct BDRVGlusterState { > struct glfs *glfs

Re: [Qemu-devel] [PATCH 1/2] block: gluster - code movements, state storage changes

2014-02-10 Thread Benoît Canet
Le Friday 07 Feb 2014 à 10:57:33 (-0500), Jeff Cody a écrit : > On Fri, Feb 07, 2014 at 08:57:35PM +0530, Bharata B Rao wrote: > > On Fri, Feb 07, 2014 at 03:22:29PM +0100, Benoît Canet wrote: > > > Le Friday 07 Feb 2014 à 09:14:50 (+0530), Bharata B Rao a écrit : > > > > On Wed, Feb 05, 2014 at 08

Re: [Qemu-devel] [PATCH 1/2] block: gluster - code movements, state storage changes

2014-02-07 Thread Benoît Canet
Le Friday 07 Feb 2014 à 20:57:35 (+0530), Bharata B Rao a écrit : > On Fri, Feb 07, 2014 at 03:22:29PM +0100, Benoît Canet wrote: > > Le Friday 07 Feb 2014 à 09:14:50 (+0530), Bharata B Rao a écrit : > > > On Wed, Feb 05, 2014 at 08:25:36PM +0100, Benoît Canet wrote: > > > > Le Tuesday 04 Feb 2014

Re: [Qemu-devel] [PATCH 1/2] block: gluster - code movements, state storage changes

2014-02-07 Thread Jeff Cody
On Fri, Feb 07, 2014 at 08:57:35PM +0530, Bharata B Rao wrote: > On Fri, Feb 07, 2014 at 03:22:29PM +0100, Benoît Canet wrote: > > Le Friday 07 Feb 2014 à 09:14:50 (+0530), Bharata B Rao a écrit : > > > On Wed, Feb 05, 2014 at 08:25:36PM +0100, Benoît Canet wrote: > > > > Le Tuesday 04 Feb 2014 à 1

Re: [Qemu-devel] [PATCH 1/2] block: gluster - code movements, state storage changes

2014-02-07 Thread Bharata B Rao
On Fri, Feb 07, 2014 at 03:22:29PM +0100, Benoît Canet wrote: > Le Friday 07 Feb 2014 à 09:14:50 (+0530), Bharata B Rao a écrit : > > On Wed, Feb 05, 2014 at 08:25:36PM +0100, Benoît Canet wrote: > > > Le Tuesday 04 Feb 2014 à 14:26:58 (-0500), Jeff Cody a écrit : > > > > > > > > +static void qem

Re: [Qemu-devel] [PATCH 1/2] block: gluster - code movements, state storage changes

2014-02-07 Thread Benoît Canet
Le Friday 07 Feb 2014 à 09:14:50 (+0530), Bharata B Rao a écrit : > On Wed, Feb 05, 2014 at 08:25:36PM +0100, Benoît Canet wrote: > > Le Tuesday 04 Feb 2014 à 14:26:58 (-0500), Jeff Cody a écrit : > > > > > > +static void qemu_gluster_parse_flags(int bdrv_flags, int *open_flags) > > > +{ > > > +

Re: [Qemu-devel] [PATCH 1/2] block: gluster - code movements, state storage changes

2014-02-06 Thread Bharata B Rao
On Wed, Feb 05, 2014 at 08:25:36PM +0100, Benoît Canet wrote: > Le Tuesday 04 Feb 2014 à 14:26:58 (-0500), Jeff Cody a écrit : > > > > +static void qemu_gluster_parse_flags(int bdrv_flags, int *open_flags) > > +{ > > +assert(open_flags != NULL); > > + > > +*open_flags |= O_BINARY; > > + >

Re: [Qemu-devel] [PATCH 1/2] block: gluster - code movements, state storage changes

2014-02-05 Thread Benoît Canet
Le Tuesday 04 Feb 2014 à 14:26:58 (-0500), Jeff Cody a écrit : > In preparation for supporting reopen on gluster, move flag > parsing out to a function. Also, store open_flags and filename > in the gluster state storage struct, and add a NULL check in the > gconf cleanup. > > Signed-off-by: Jeff

[Qemu-devel] [PATCH 1/2] block: gluster - code movements, state storage changes

2014-02-04 Thread Jeff Cody
In preparation for supporting reopen on gluster, move flag parsing out to a function. Also, store open_flags and filename in the gluster state storage struct, and add a NULL check in the gconf cleanup. Signed-off-by: Jeff Cody --- block/gluster.c | 48 ---