Re: [Qemu-devel] [PATCH 1/2] block: flush backing_hd in the right place

2010-01-14 Thread Kevin Wolf
Am 14.01.2010 00:26, schrieb Anthony Liguori: > On 01/12/2010 06:49 AM, Christoph Hellwig wrote: >> The backing device is only modified from bdrv_commit. So instead of >> flushing it every time bdrv_flush is called for the front-end device >> only flush it after we're written data to it in bdrv_co

Re: [Qemu-devel] [PATCH 1/2] block: flush backing_hd in the right place

2010-01-13 Thread Anthony Liguori
On 01/12/2010 06:49 AM, Christoph Hellwig wrote: The backing device is only modified from bdrv_commit. So instead of flushing it every time bdrv_flush is called for the front-end device only flush it after we're written data to it in bdrv_commit. Signed-off-by: Christoph Hellwig Applied.

Re: [Qemu-devel] [PATCH 1/2] block: flush backing_hd in the right place

2010-01-12 Thread Christoph Hellwig
On Tue, Jan 12, 2010 at 06:42:20PM +0100, Kevin Wolf wrote: > > @@ -623,6 +623,12 @@ int bdrv_commit(BlockDriverState *bs) > > if (drv->bdrv_make_empty) > > return drv->bdrv_make_empty(bs); > > > > +/* > > + * Make sure all data we wrote to the backing device is actually > > +

Re: [Qemu-devel] [PATCH 1/2] block: flush backing_hd in the right place

2010-01-12 Thread Kevin Wolf
Am 12.01.2010 13:49, schrieb Christoph Hellwig: > > The backing device is only modified from bdrv_commit. So instead of > flushing it every time bdrv_flush is called for the front-end device > only flush it after we're written data to it in bdrv_commit. > > Signed-off-by: Christoph Hellwig > >

[Qemu-devel] [PATCH 1/2] block: flush backing_hd in the right place

2010-01-12 Thread Christoph Hellwig
The backing device is only modified from bdrv_commit. So instead of flushing it every time bdrv_flush is called for the front-end device only flush it after we're written data to it in bdrv_commit. Signed-off-by: Christoph Hellwig Index: qemu/block.c ===