Re: [Qemu-devel] [PATCH 1/2] add visitor for parsing int[KMGT] input string

2012-12-14 Thread Eduardo Habkost
On Fri, Dec 14, 2012 at 02:20:48PM +0100, Igor Mammedov wrote: > On Wed, 12 Dec 2012 16:16:42 -0200 > Eduardo Habkost wrote: > > > On Mon, Dec 10, 2012 at 10:33:06PM +0100, Igor Mammedov wrote: > > > Caller of visit_type_suffixed_int() have to specify > > > value of 'K' suffix using suffix_factor

Re: [Qemu-devel] [PATCH 1/2] add visitor for parsing int[KMGT] input string

2012-12-14 Thread Igor Mammedov
On Wed, 12 Dec 2012 16:16:42 -0200 Eduardo Habkost wrote: > On Mon, Dec 10, 2012 at 10:33:06PM +0100, Igor Mammedov wrote: > > Caller of visit_type_suffixed_int() have to specify > > value of 'K' suffix using suffix_factor argument. > > Example of selecting suffix_factor value: > > * Kbytes: 102

Re: [Qemu-devel] [PATCH 1/2] add visitor for parsing int[KMGT] input string

2012-12-12 Thread Eduardo Habkost
On Mon, Dec 10, 2012 at 10:33:06PM +0100, Igor Mammedov wrote: > Caller of visit_type_suffixed_int() have to specify > value of 'K' suffix using suffix_factor argument. > Example of selecting suffix_factor value: > * Kbytes: 1024 > * Khz: 1000 > > Signed-off-by: Igor Mammedov Reviewed-by: Edua

[Qemu-devel] [PATCH 1/2] add visitor for parsing int[KMGT] input string

2012-12-10 Thread Igor Mammedov
Caller of visit_type_suffixed_int() have to specify value of 'K' suffix using suffix_factor argument. Example of selecting suffix_factor value: * Kbytes: 1024 * Khz: 1000 Signed-off-by: Igor Mammedov --- v3: - Fix errp check. Spotted-By: Andreas Färber - s/type_unit_suffixed_int/type_suff