Re: [Qemu-devel] [PATCH 1/2] Keep track of ISA ports ISA device is using in qdev.

2010-10-26 Thread Gleb Natapov
On Tue, Oct 26, 2010 at 11:49:26AM +0200, Markus Armbruster wrote: > Gleb Natapov writes: > > > On Mon, Oct 25, 2010 at 08:01:13PM +0200, Markus Armbruster wrote: > >> Gleb Natapov writes: > >> > >> > On Mon, Oct 25, 2010 at 05:06:51PM +0200, Markus Armbruster wrote: > >> >> Gleb Natapov write

Re: [Qemu-devel] [PATCH 1/2] Keep track of ISA ports ISA device is using in qdev.

2010-10-26 Thread Markus Armbruster
Gleb Natapov writes: > On Mon, Oct 25, 2010 at 08:01:13PM +0200, Markus Armbruster wrote: >> Gleb Natapov writes: >> >> > On Mon, Oct 25, 2010 at 05:06:51PM +0200, Markus Armbruster wrote: >> >> Gleb Natapov writes: >> >> >> >> > Prevent two devices from claiming the same io port. >> >> >> >

Re: [Qemu-devel] [PATCH 1/2] Keep track of ISA ports ISA device is using in qdev.

2010-10-25 Thread Markus Armbruster
Gleb Natapov writes: > On Mon, Oct 25, 2010 at 05:06:51PM +0200, Markus Armbruster wrote: >> Gleb Natapov writes: >> >> > Prevent two devices from claiming the same io port. >> >> Really? >> >> Your new check for double-claim is in the new isa_init_ioport(), which >> is for ISADevice only. T

Re: [Qemu-devel] [PATCH 1/2] Keep track of ISA ports ISA device is using in qdev.

2010-10-25 Thread Gleb Natapov
On Mon, Oct 25, 2010 at 08:01:13PM +0200, Markus Armbruster wrote: > Gleb Natapov writes: > > > On Mon, Oct 25, 2010 at 05:06:51PM +0200, Markus Armbruster wrote: > >> Gleb Natapov writes: > >> > >> > Prevent two devices from claiming the same io port. > >> > >> Really? > >> > >> Your new che

Re: [Qemu-devel] [PATCH 1/2] Keep track of ISA ports ISA device is using in qdev.

2010-10-25 Thread Gleb Natapov
On Mon, Oct 25, 2010 at 05:06:51PM +0200, Markus Armbruster wrote: > Gleb Natapov writes: > > > Prevent two devices from claiming the same io port. > > Really? > > Your new check for double-claim is in the new isa_init_ioport(), which > is for ISADevice only. Thus, only qdevified ISA devices c

Re: [Qemu-devel] [PATCH 1/2] Keep track of ISA ports ISA device is using in qdev.

2010-10-25 Thread Markus Armbruster
Gleb Natapov writes: > Prevent two devices from claiming the same io port. Really? Your new check for double-claim is in the new isa_init_ioport(), which is for ISADevice only. Thus, only qdevified ISA devices can opt for this protection, by calling isa_init_ioport(). It doesn't protect from

[Qemu-devel] [PATCH 1/2] Keep track of ISA ports ISA device is using in qdev.

2010-10-24 Thread Gleb Natapov
Prevent two devices from claiming the same io port. Signed-off-by: Gleb Natapov --- hw/cs4231a.c |1 + hw/fdc.c |3 +++ hw/gus.c |4 hw/ide/isa.c |2 ++ hw/isa-bus.c | 31 +++ hw/isa.h |4 hw/m48t59.c