Re: [Qemu-devel] [PATCH 1/2] Fix tlb_vaddr_to_host with CONFIG_USER_ONLY

2016-08-03 Thread Benjamin Herrenschmidt
On Wed, 2016-08-03 at 12:19 +0100, Peter Maydell wrote: >  > I don't understand why this didn't cause compile failures... I didn't either. I found: include/qom/cpu.h:typedef uint64_t vaddr; So g2h becomes something like (target_ulong)(uint64) + guest_base Which does build ;-) Cheers, Ben.

Re: [Qemu-devel] [PATCH 1/2] Fix tlb_vaddr_to_host with CONFIG_USER_ONLY

2016-08-03 Thread Peter Maydell
On 3 August 2016 at 04:15, Benjamin Herrenschmidt wrote: > We use the wrong argument name for the g2h() macro ! > > Signed-off-by: Benjamin Herrenschmidt > --- > > Not sure who to CC for this... > > include/exec/cpu_ldst.h | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/

[Qemu-devel] [PATCH 1/2] Fix tlb_vaddr_to_host with CONFIG_USER_ONLY

2016-08-02 Thread Benjamin Herrenschmidt
We use the wrong argument name for the g2h() macro ! Signed-off-by: Benjamin Herrenschmidt --- Not sure who to CC for this... include/exec/cpu_ldst.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/include/exec/cpu_ldst.h b/include/exec/cpu_ldst.h index b573df5..6eb5fe8 100