Re: [Qemu-devel] [PATCH 1/1] xen-hvm.c: Add support for Xen access to vmport

2014-10-01 Thread Paul Durrant
ensource.com; Stefano Stabellini; Markus Armbruster; > Marcel Apfelbaum; Alexander Graf; qemu-devel@nongnu.org; Michael S. > Tsirkin; Anthony Liguori; Andreas Färber > Subject: Re: [Qemu-devel] [PATCH 1/1] xen-hvm.c: Add support for Xen > access to vmport > > On Wed, 1 Oct 2014, Slu

Re: [Qemu-devel] [PATCH 1/1] xen-hvm.c: Add support for Xen access to vmport

2014-10-01 Thread Don Slutz
On 10/01/14 05:20, Stefano Stabellini wrote: On Wed, 1 Oct 2014, Slutz, Donald Christopher wrote: On 09/30/14 06:35, Stefano Stabellini wrote: On Mon, 29 Sep 2014, Don Slutz wrote: On 09/29/14 06:25, Stefano Stabellini wrote: On Mon, 29 Sep 2014, Stefano Stabellini wrote: On Fri, 26 Sep 2014

Re: [Qemu-devel] [PATCH 1/1] xen-hvm.c: Add support for Xen access to vmport

2014-10-01 Thread Stefano Stabellini
On Wed, 1 Oct 2014, Slutz, Donald Christopher wrote: > On 09/30/14 06:35, Stefano Stabellini wrote: > > On Mon, 29 Sep 2014, Don Slutz wrote: > >> On 09/29/14 06:25, Stefano Stabellini wrote: > >>> On Mon, 29 Sep 2014, Stefano Stabellini wrote: > On Fri, 26 Sep 2014, Don Slutz wrote: > > T

Re: [Qemu-devel] [PATCH 1/1] xen-hvm.c: Add support for Xen access to vmport

2014-09-30 Thread Slutz, Donald Christopher
On 09/30/14 06:35, Stefano Stabellini wrote: > On Mon, 29 Sep 2014, Don Slutz wrote: >> On 09/29/14 06:25, Stefano Stabellini wrote: >>> On Mon, 29 Sep 2014, Stefano Stabellini wrote: On Fri, 26 Sep 2014, Don Slutz wrote: > This adds synchronisation of the vcpu registers > between Xen

Re: [Qemu-devel] [PATCH 1/1] xen-hvm.c: Add support for Xen access to vmport

2014-09-30 Thread Stefano Stabellini
On Mon, 29 Sep 2014, Don Slutz wrote: > On 09/29/14 06:25, Stefano Stabellini wrote: > > On Mon, 29 Sep 2014, Stefano Stabellini wrote: > > > On Fri, 26 Sep 2014, Don Slutz wrote: > > > > This adds synchronisation of the vcpu registers > > > > between Xen and QEMU. > > > > > > > > Signed-off-by: D

Re: [Qemu-devel] [PATCH 1/1] xen-hvm.c: Add support for Xen access to vmport

2014-09-30 Thread Paolo Bonzini
Il 30/09/2014 03:05, Don Slutz ha scritto: > > Basically current_cpu is NULL here, and I think that no CPU objects > have been created for Xen. So there is no VCPU object to select. CPU objects are created for Xen HVM, though not for PV. You would have to visit the list of CPUs and fill in an a

Re: [Qemu-devel] [PATCH 1/1] xen-hvm.c: Add support for Xen access to vmport

2014-09-29 Thread Don Slutz
On 09/29/14 09:14, Paolo Bonzini wrote: Il 29/09/2014 14:57, Alexander Graf ha scritto: Yeah, that would be possible. You do not even need synchronize_state, it seems to me that it introduces more complication for little gain. Well, it makes all accels behave the same and keep information alw

Re: [Qemu-devel] [PATCH 1/1] xen-hvm.c: Add support for Xen access to vmport

2014-09-29 Thread Don Slutz
On 09/29/14 07:53, Alexander Graf wrote: On 29.09.14 13:10, Paolo Bonzini wrote: Il 29/09/2014 10:12, Alexander Graf ha scritto: Could you instead plug into the existing cpu_synchronize_registers() framework and just implement register synchronization for the Xen side, just like it's been done

Re: [Qemu-devel] [PATCH 1/1] xen-hvm.c: Add support for Xen access to vmport

2014-09-29 Thread Don Slutz
On 09/29/14 06:25, Stefano Stabellini wrote: On Mon, 29 Sep 2014, Stefano Stabellini wrote: On Fri, 26 Sep 2014, Don Slutz wrote: This adds synchronisation of the vcpu registers between Xen and QEMU. Signed-off-by: Don Slutz [...] diff --git a/xen-hvm.c b/xen-hvm.c index 05e522c..e1274bb 1

Re: [Qemu-devel] [PATCH 1/1] xen-hvm.c: Add support for Xen access to vmport

2014-09-29 Thread Paolo Bonzini
Il 29/09/2014 14:57, Alexander Graf ha scritto: >> > Yeah, that would be possible. You do not even need synchronize_state, >> > it seems to me that it introduces more complication for little gain. > Well, it makes all accels behave the same and keep information always at > a single entity (the env

Re: [Qemu-devel] [PATCH 1/1] xen-hvm.c: Add support for Xen access to vmport

2014-09-29 Thread Alexander Graf
On 29.09.14 14:21, Paolo Bonzini wrote: > Il 29/09/2014 13:53, Alexander Graf ha scritto: >> >> cpu_handle_ioreq() >> { >> ... >> >> if (req->type == IOPORT_REGISTERS_SYNCHRONIZED) { >> cpu->xen_vcpu_dirty = true; >> synchronize_xen_to_env(xenptr, cpu); >> } >> >>

Re: [Qemu-devel] [PATCH 1/1] xen-hvm.c: Add support for Xen access to vmport

2014-09-29 Thread Paolo Bonzini
Il 29/09/2014 13:53, Alexander Graf ha scritto: > > cpu_handle_ioreq() > { > ... > > if (req->type == IOPORT_REGISTERS_SYNCHRONIZED) { > cpu->xen_vcpu_dirty = true; > synchronize_xen_to_env(xenptr, cpu); > } > > handle_ioreq(); > > if (req->type == IOPORT

Re: [Qemu-devel] [PATCH 1/1] xen-hvm.c: Add support for Xen access to vmport

2014-09-29 Thread Alexander Graf
On 29.09.14 13:10, Paolo Bonzini wrote: > Il 29/09/2014 10:12, Alexander Graf ha scritto: >> Could you instead plug into the existing cpu_synchronize_registers() >> framework and just implement register synchronization for the Xen side, >> just like it's been done for KVM? :) > > No, because her

Re: [Qemu-devel] [PATCH 1/1] xen-hvm.c: Add support for Xen access to vmport

2014-09-29 Thread Paolo Bonzini
Il 29/09/2014 10:12, Alexander Graf ha scritto: > Could you instead plug into the existing cpu_synchronize_registers() > framework and just implement register synchronization for the Xen side, > just like it's been done for KVM? :) No, because here it's Xen that sends out the register contents. W

Re: [Qemu-devel] [PATCH 1/1] xen-hvm.c: Add support for Xen access to vmport

2014-09-29 Thread Stefano Stabellini
On Mon, 29 Sep 2014, Stefano Stabellini wrote: > On Fri, 26 Sep 2014, Don Slutz wrote: > > This adds synchronisation of the vcpu registers > > between Xen and QEMU. > > > > Signed-off-by: Don Slutz > > [...] > > > diff --git a/xen-hvm.c b/xen-hvm.c > > index 05e522c..e1274bb 100644 > > --- a/xe

Re: [Qemu-devel] [PATCH 1/1] xen-hvm.c: Add support for Xen access to vmport

2014-09-29 Thread Stefano Stabellini
On Fri, 26 Sep 2014, Don Slutz wrote: > This adds synchronisation of the vcpu registers > between Xen and QEMU. > > Signed-off-by: Don Slutz [...] > diff --git a/xen-hvm.c b/xen-hvm.c > index 05e522c..e1274bb 100644 > --- a/xen-hvm.c > +++ b/xen-hvm.c > @@ -857,14 +857,48 @@ static void cpu_han

Re: [Qemu-devel] [PATCH 1/1] xen-hvm.c: Add support for Xen access to vmport

2014-09-29 Thread Alexander Graf
On 26.09.14 20:47, Don Slutz wrote: > This adds synchronisation of the vcpu registers > between Xen and QEMU. > > Signed-off-by: Don Slutz Could you instead plug into the existing cpu_synchronize_registers() framework and just implement register synchronization for the Xen side, just like it's

[Qemu-devel] [PATCH 1/1] xen-hvm.c: Add support for Xen access to vmport

2014-09-26 Thread Don Slutz
This adds synchronisation of the vcpu registers between Xen and QEMU. Signed-off-by: Don Slutz --- hw/misc/vmport.c | 32 include/hw/xen/xen.h | 6 ++ vl.c | 1 + xen-hvm.c| 38 -- 4 files