Re: [Qemu-devel] [PATCH 1/1] rng backend: open backend in blocking mode

2013-04-07 Thread Amit Shah
On (Wed) 03 Apr 2013 [15:08:40], Anthony Liguori wrote: > Amit Shah writes: > > > On (Tue) 02 Apr 2013 [07:52:19], Anthony Liguori wrote: > >> Amit Shah writes: > >> > >> >> > backends/rng-random.c:44:entropy_available: assertion failed: (len != > >> >> > -1) > >> >> > > >> >> > without this f

Re: [Qemu-devel] [PATCH 1/1] rng backend: open backend in blocking mode

2013-04-03 Thread Anthony Liguori
Amit Shah writes: > On (Tue) 02 Apr 2013 [07:52:19], Anthony Liguori wrote: >> Amit Shah writes: >> >> >> > backends/rng-random.c:44:entropy_available: assertion failed: (len != >> >> > -1) >> >> > >> >> > without this fix. >> >> >> >> This fix would cause QEMU to block indefinitely which I d

Re: [Qemu-devel] [PATCH 1/1] rng backend: open backend in blocking mode

2013-04-02 Thread Amit Shah
On (Tue) 02 Apr 2013 [07:52:19], Anthony Liguori wrote: > Amit Shah writes: > > > On (Mon) 01 Apr 2013 [09:02:46], Anthony Liguori wrote: > >> Amit Shah writes: > >> > >> > Opening backends in non-blocking mode isn't necessary, we don't do > >> > anything while waiting for data. > >> > > >> > T

Re: [Qemu-devel] [PATCH 1/1] rng backend: open backend in blocking mode

2013-04-02 Thread Anthony Liguori
Amit Shah writes: > On (Mon) 01 Apr 2013 [09:02:46], Anthony Liguori wrote: >> Amit Shah writes: >> >> > Opening backends in non-blocking mode isn't necessary, we don't do >> > anything while waiting for data. >> > >> > This also excuses us from checking for EAGAIN, which for the default >> > r

Re: [Qemu-devel] [PATCH 1/1] rng backend: open backend in blocking mode

2013-04-02 Thread Amit Shah
On (Mon) 01 Apr 2013 [09:02:46], Anthony Liguori wrote: > Amit Shah writes: > > > Opening backends in non-blocking mode isn't necessary, we don't do > > anything while waiting for data. > > > > This also excuses us from checking for EAGAIN, which for the default > > random backend, is a very comm

Re: [Qemu-devel] [PATCH 1/1] rng backend: open backend in blocking mode

2013-04-01 Thread Anthony Liguori
Amit Shah writes: > Opening backends in non-blocking mode isn't necessary, we don't do > anything while waiting for data. > > This also excuses us from checking for EAGAIN, which for the default > random backend, is a very common return error type. It's not common... It really shouldn't happen

[Qemu-devel] [PATCH 1/1] rng backend: open backend in blocking mode

2013-04-01 Thread Amit Shah
Opening backends in non-blocking mode isn't necessary, we don't do anything while waiting for data. This also excuses us from checking for EAGAIN, which for the default random backend, is a very common return error type. Starting the guest with '-device virtio-rng-pci', issuing a 'cat /dev/hwrng'