Re: [Qemu-devel] [PATCH 1/1] libqtest: Improve error reporting for bad read from QEMU

2018-08-17 Thread Paolo Bonzini
On 15/08/2018 16:19, Markus Armbruster wrote: > When read() from the qtest socket or the QMP socket fails or EOFs, we > report "Broken pipe" and exit(1). This commonly happens when QEMU > crashes. It also happens when QEMU refuses to run because the test > passed it bad arguments. Sadly, we negl

Re: [Qemu-devel] [PATCH 1/1] libqtest: Improve error reporting for bad read from QEMU

2018-08-15 Thread Markus Armbruster
Philippe Mathieu-Daudé writes: > On 08/15/2018 11:19 AM, Markus Armbruster wrote: >> When read() from the qtest socket or the QMP socket fails or EOFs, we >> report "Broken pipe" and exit(1). This commonly happens when QEMU >> crashes. It also happens when QEMU refuses to run because the test >

Re: [Qemu-devel] [PATCH 1/1] libqtest: Improve error reporting for bad read from QEMU

2018-08-15 Thread Eric Blake
On 08/15/2018 09:19 AM, Markus Armbruster wrote: When read() from the qtest socket or the QMP socket fails or EOFs, we report "Broken pipe" and exit(1). This commonly happens when QEMU crashes. It also happens when QEMU refuses to run because the test passed it bad arguments. Sadly, we neglect

Re: [Qemu-devel] [PATCH 1/1] libqtest: Improve error reporting for bad read from QEMU

2018-08-15 Thread Philippe Mathieu-Daudé
On 08/15/2018 11:19 AM, Markus Armbruster wrote: > When read() from the qtest socket or the QMP socket fails or EOFs, we > report "Broken pipe" and exit(1). This commonly happens when QEMU > crashes. It also happens when QEMU refuses to run because the test > passed it bad arguments. Sadly, we n

[Qemu-devel] [PATCH 1/1] libqtest: Improve error reporting for bad read from QEMU

2018-08-15 Thread Markus Armbruster
When read() from the qtest socket or the QMP socket fails or EOFs, we report "Broken pipe" and exit(1). This commonly happens when QEMU crashes. It also happens when QEMU refuses to run because the test passed it bad arguments. Sadly, we neglect to report either. Improve this by calling abort()