Re: [Qemu-devel] [PATCH 1/1] ide: unify io_buffer_offset increments

2015-09-08 Thread John Snow
On 09/07/2015 12:37 PM, Paolo Bonzini wrote: > > > On 26/08/2015 01:45, John Snow wrote: >> IDEState's io_buffer_offset was originally added to keep track of offsets >> in AHCI rather exclusively, but it was added to IDEState instead of an >> AHCI-specific structure. > > Interesting to see som

Re: [Qemu-devel] [PATCH 1/1] ide: unify io_buffer_offset increments

2015-09-07 Thread Paolo Bonzini
On 26/08/2015 01:45, John Snow wrote: > IDEState's io_buffer_offset was originally added to keep track of offsets > in AHCI rather exclusively, but it was added to IDEState instead of an > AHCI-specific structure. Interesting to see something weird turn into feature. :) Reviewed-by: Paolo Bonzi

[Qemu-devel] [PATCH 1/1] ide: unify io_buffer_offset increments

2015-08-25 Thread John Snow
IDEState's io_buffer_offset was originally added to keep track of offsets in AHCI rather exclusively, but it was added to IDEState instead of an AHCI-specific structure. AHCI fakes all PIO transfers using DMA and a scatter-gather list. When the core or atapi layers invoke HBA-specific mechanisms f