Re: [Qemu-devel] [PATCH 1/1] hw/audio/sb16.c: missing break statement

2018-02-08 Thread Daniel Henrique Barboza
Hey, On 02/08/2018 10:15 AM, Philippe Mathieu-Daudé wrote: Hi Daniel, On 02/08/2018 07:57 AM, Daniel Henrique Barboza wrote: This patch adds a break in the switch() statement of complete(), value 0x42: case 0x42: /* FT2 sets output freq with this, go figure */ qemu_

Re: [Qemu-devel] [PATCH 1/1] hw/audio/sb16.c: missing break statement

2018-02-08 Thread Peter Maydell
On 8 February 2018 at 13:34, Philippe Mathieu-Daudé wrote: > Now I see Fabrice comment "FT2 sets output freq with this, go figure" > and agree with him. > > I like to think this is a bug in Fast Tracker 2, so Peter suggestion > about using LOG_GUEST_ERROR here might be clever. > >> >> So imho the

Re: [Qemu-devel] [PATCH 1/1] hw/audio/sb16.c: missing break statement

2018-02-08 Thread Philippe Mathieu-Daudé
On 02/08/2018 10:16 AM, Philippe Mathieu-Daudé wrote: > On 02/08/2018 10:01 AM, Peter Maydell wrote: >> On 8 February 2018 at 12:15, Philippe Mathieu-Daudé wrote: >>> Hi Daniel, >>> >>> On 02/08/2018 07:57 AM, Daniel Henrique Barboza wrote: This patch adds a break in the switch() statement of

Re: [Qemu-devel] [PATCH 1/1] hw/audio/sb16.c: missing break statement

2018-02-08 Thread Philippe Mathieu-Daudé
On 02/08/2018 10:01 AM, Peter Maydell wrote: > On 8 February 2018 at 12:15, Philippe Mathieu-Daudé wrote: >> Hi Daniel, >> >> On 02/08/2018 07:57 AM, Daniel Henrique Barboza wrote: >>> This patch adds a break in the switch() statement of complete(), >>> value 0x42: >>> >>> case 0x42:

Re: [Qemu-devel] [PATCH 1/1] hw/audio/sb16.c: missing break statement

2018-02-08 Thread Daniel P . Berrangé
On Thu, Feb 08, 2018 at 09:15:10AM -0300, Philippe Mathieu-Daudé wrote: > Hi Daniel, > > On 02/08/2018 07:57 AM, Daniel Henrique Barboza wrote: > > This patch adds a break in the switch() statement of complete(), > > value 0x42: > > > > case 0x42: /* FT2 sets output freq with thi

Re: [Qemu-devel] [PATCH 1/1] hw/audio/sb16.c: missing break statement

2018-02-08 Thread Peter Maydell
On 8 February 2018 at 12:15, Philippe Mathieu-Daudé wrote: > Hi Daniel, > > On 02/08/2018 07:57 AM, Daniel Henrique Barboza wrote: >> This patch adds a break in the switch() statement of complete(), >> value 0x42: >> >> case 0x42: /* FT2 sets output freq with this, go figure */ >>

Re: [Qemu-devel] [PATCH 1/1] hw/audio/sb16.c: missing break statement

2018-02-08 Thread Philippe Mathieu-Daudé
Hi Daniel, On 02/08/2018 07:57 AM, Daniel Henrique Barboza wrote: > This patch adds a break in the switch() statement of complete(), > value 0x42: > > case 0x42: /* FT2 sets output freq with this, go figure */ > qemu_log_mask(LOG_UNIMP, "cmd 0x42 might not do what it thin

[Qemu-devel] [PATCH 1/1] hw/audio/sb16.c: missing break statement

2018-02-08 Thread Daniel Henrique Barboza
This patch adds a break in the switch() statement of complete(), value 0x42: case 0x42: /* FT2 sets output freq with this, go figure */ qemu_log_mask(LOG_UNIMP, "cmd 0x42 might not do what it think it" " should\n"); break; <--- case 0x