Re: [Qemu-devel] [PATCH 1/1] char/serial: Fix emptyness handling

2014-03-18 Thread Don Slutz
On 03/17/14 19:02, Peter Crosthwaite wrote: On Thu, Feb 20, 2014 at 4:30 AM, Don Slutz wrote: The commit 88c1ee73d3231c74ff90bcfc084a7589670ec244 char/serial: Fix emptyness check Still causes extra NULL byte(s) to be sent. So if the fifo is empty, do not send an extra NULL byte. Signed-off-b

Re: [Qemu-devel] [PATCH 1/1] char/serial: Fix emptyness handling

2014-03-17 Thread Peter Crosthwaite
On Thu, Feb 20, 2014 at 4:30 AM, Don Slutz wrote: > The commit 88c1ee73d3231c74ff90bcfc084a7589670ec244 > char/serial: Fix emptyness check > > Still causes extra NULL byte(s) to be sent. > > So if the fifo is empty, do not send an extra NULL byte. > > Signed-off-by: Don Slutz > --- > hw/char/ser

Re: [Qemu-devel] [PATCH 1/1] char/serial: Fix emptyness handling

2014-03-17 Thread Peter Crosthwaite
On Thu, Feb 20, 2014 at 4:30 AM, Don Slutz wrote: > The commit 88c1ee73d3231c74ff90bcfc084a7589670ec244 > char/serial: Fix emptyness check > > Still causes extra NULL byte(s) to be sent. > > So if the fifo is empty, do not send an extra NULL byte. > > Signed-off-by: Don Slutz Reviewed-by: Peter

Re: [Qemu-devel] [PATCH 1/1] char/serial: Fix emptyness handling

2014-02-24 Thread Don Slutz
On 02/19/14 13:30, Don Slutz wrote: The commit 88c1ee73d3231c74ff90bcfc084a7589670ec244 char/serial: Fix emptyness check Still causes extra NULL byte(s) to be sent. So if the fifo is empty, do not send an extra NULL byte. Signed-off-by: Don Slutz --- hw/char/serial.c | 5 +++-- 1 file chan

[Qemu-devel] [PATCH 1/1] char/serial: Fix emptyness handling

2014-02-19 Thread Don Slutz
The commit 88c1ee73d3231c74ff90bcfc084a7589670ec244 char/serial: Fix emptyness check Still causes extra NULL byte(s) to be sent. So if the fifo is empty, do not send an extra NULL byte. Signed-off-by: Don Slutz --- hw/char/serial.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) di