Re: [Qemu-devel] [PATCH 1/1] block/vpc.c: Detect too-large vpc file

2011-07-27 Thread Serge E. Hallyn
Quoting Kevin Wolf (kw...@redhat.com): > > The footer->size appears to be double the 'real' size. So I'm actually > > doing > > the blow. Does this seem sensible? > > Double size sounds really weird. 'qemu-img create' uses the size in > bytes for it. Is that wrong? > > > Doing it this way, try

Re: [Qemu-devel] [PATCH 1/1] block/vpc.c: Detect too-large vpc file

2011-07-27 Thread Kevin Wolf
Am 26.07.2011 22:26, schrieb Serge E. Hallyn: > Quoting Kevin Wolf (kw...@redhat.com): >> I think that footer->size contains the real size. Maybe we should do >> something like this: >> if (footer->size > 65536 * 16 * 255 * 512) { >> bs->total_sectors = footer->size / 512; >> } else { >> bs

Re: [Qemu-devel] [PATCH 1/1] block/vpc.c: Detect too-large vpc file

2011-07-27 Thread Kevin Wolf
Am 26.07.2011 22:26, schrieb Serge E. Hallyn: > Quoting Kevin Wolf (kw...@redhat.com): >> Am 26.07.2011 18:08, schrieb Serge E. Hallyn: >>> Quoting Kevin Wolf (kw...@redhat.com): Am 25.07.2011 20:34, schrieb Serge E. Hallyn: > VHD files technically can be up to 2Tb, but virtual pc is limit

Re: [Qemu-devel] [PATCH 1/1] block/vpc.c: Detect too-large vpc file

2011-07-26 Thread Serge E. Hallyn
Quoting Kevin Wolf (kw...@redhat.com): > Am 26.07.2011 18:08, schrieb Serge E. Hallyn: > > Quoting Kevin Wolf (kw...@redhat.com): > >> Am 25.07.2011 20:34, schrieb Serge E. Hallyn: > >>> VHD files technically can be up to 2Tb, but virtual pc is limited > >>> to 127G. Currently qemu-img refused to

Re: [Qemu-devel] [PATCH 1/1] block/vpc.c: Detect too-large vpc file

2011-07-26 Thread Kevin Wolf
Am 26.07.2011 18:08, schrieb Serge E. Hallyn: > Quoting Kevin Wolf (kw...@redhat.com): >> Am 25.07.2011 20:34, schrieb Serge E. Hallyn: >>> VHD files technically can be up to 2Tb, but virtual pc is limited >>> to 127G. Currently qemu-img refused to create vpc files > 127G, >>> but it is failing to

Re: [Qemu-devel] [PATCH 1/1] block/vpc.c: Detect too-large vpc file

2011-07-26 Thread Serge E. Hallyn
Quoting Kevin Wolf (kw...@redhat.com): > Am 25.07.2011 20:34, schrieb Serge E. Hallyn: > > VHD files technically can be up to 2Tb, but virtual pc is limited > > to 127G. Currently qemu-img refused to create vpc files > 127G, > > but it is failing to return error when converting from a non-vpc > >

Re: [Qemu-devel] [PATCH 1/1] block/vpc.c: Detect too-large vpc file

2011-07-26 Thread Kevin Wolf
Am 25.07.2011 20:34, schrieb Serge E. Hallyn: > VHD files technically can be up to 2Tb, but virtual pc is limited > to 127G. Currently qemu-img refused to create vpc files > 127G, > but it is failing to return error when converting from a non-vpc > VHD file which is >127G. It returns success, but

[Qemu-devel] [PATCH 1/1] block/vpc.c: Detect too-large vpc file

2011-07-25 Thread Serge E. Hallyn
VHD files technically can be up to 2Tb, but virtual pc is limited to 127G. Currently qemu-img refused to create vpc files > 127G, but it is failing to return error when converting from a non-vpc VHD file which is >127G. It returns success, but creates a truncated converted image. Also, qemu-img