Re: [Qemu-devel] [PATCH 1/1] Stop reinit of XBZRLE.lock

2014-03-19 Thread Markus Armbruster
"Dr. David Alan Gilbert" writes: > * Markus Armbruster (arm...@redhat.com) wrote: >> "Dr. David Alan Gilbert" writes: >> >> > * Markus Armbruster (arm...@redhat.com) wrote: >> >> "Dr. David Alan Gilbert (git)" writes: >> > >> > >> > >> >> > diff --git a/arch_init.c b/arch_init.c >> >> > index

Re: [Qemu-devel] [PATCH 1/1] Stop reinit of XBZRLE.lock

2014-03-19 Thread Dr. David Alan Gilbert
* Markus Armbruster (arm...@redhat.com) wrote: > "Dr. David Alan Gilbert" writes: > > > * Markus Armbruster (arm...@redhat.com) wrote: > >> "Dr. David Alan Gilbert (git)" writes: > > > > > > > >> > diff --git a/arch_init.c b/arch_init.c > >> > index 60c975d..16474b5 100644 > >> > --- a/arch_ini

Re: [Qemu-devel] [PATCH 1/1] Stop reinit of XBZRLE.lock

2014-03-19 Thread Markus Armbruster
"Dr. David Alan Gilbert" writes: > * Markus Armbruster (arm...@redhat.com) wrote: >> "Dr. David Alan Gilbert (git)" writes: > > > >> > diff --git a/arch_init.c b/arch_init.c >> > index 60c975d..16474b5 100644 >> > --- a/arch_init.c >> > +++ b/arch_init.c >> > @@ -167,10 +167,13 @@ static struct

Re: [Qemu-devel] [PATCH 1/1] Stop reinit of XBZRLE.lock

2014-03-18 Thread Dr. David Alan Gilbert
* Markus Armbruster (arm...@redhat.com) wrote: > "Dr. David Alan Gilbert (git)" writes: > > diff --git a/arch_init.c b/arch_init.c > > index 60c975d..16474b5 100644 > > --- a/arch_init.c > > +++ b/arch_init.c > > @@ -167,10 +167,13 @@ static struct { > > /* Cache for XBZRLE, Protected by l

Re: [Qemu-devel] [PATCH 1/1] Stop reinit of XBZRLE.lock

2014-03-18 Thread Dr. David Alan Gilbert
* (chenliang0...@icloud.com) wrote: > nice catch > > > From: "Dr. David Alan Gilbert" > > > > Markus Armbruster spotted that the XBZRLE.lock might get initalised > > multiple times in the case of a second attempted migration, and > > that's undefined behaviour for pthread_mutex_init. > > >

Re: [Qemu-devel] [PATCH 1/1] Stop reinit of XBZRLE.lock

2014-03-18 Thread Markus Armbruster
"Dr. David Alan Gilbert (git)" writes: > From: "Dr. David Alan Gilbert" > > Markus Armbruster spotted that the XBZRLE.lock might get initalised > multiple times in the case of a second attempted migration, and > that's undefined behaviour for pthread_mutex_init. > > This patch adds a flag to sto

Re: [Qemu-devel] [PATCH 1/1] Stop reinit of XBZRLE.lock

2014-03-18 Thread 陈梁
nice catch > From: "Dr. David Alan Gilbert" > > Markus Armbruster spotted that the XBZRLE.lock might get initalised > multiple times in the case of a second attempted migration, and > that's undefined behaviour for pthread_mutex_init. > > This patch adds a flag to stop re-initialisation - findi

[Qemu-devel] [PATCH 1/1] Stop reinit of XBZRLE.lock

2014-03-18 Thread Dr. David Alan Gilbert (git)
From: "Dr. David Alan Gilbert" Markus Armbruster spotted that the XBZRLE.lock might get initalised multiple times in the case of a second attempted migration, and that's undefined behaviour for pthread_mutex_init. This patch adds a flag to stop re-initialisation - finding somewhere to cleanly de