Re: [Qemu-devel] [PATCH 1/1] Fix conversion from uint64 to float128

2018-05-11 Thread Richard Henderson
On 05/11/2018 12:10 AM, Petr Tesarik wrote: > The significand is passed to normalizeRoundAndPackFloat128() as high > first, low second. The current code passes the integer first, so the > result is incorrectly shifted left by 64 bits. > > This bug affects the emulation of s390x instruction CXLGBR

Re: [Qemu-devel] [PATCH 1/1] Fix conversion from uint64 to float128

2018-05-11 Thread Peter Maydell
On 11 May 2018 at 08:10, Petr Tesarik wrote: > The significand is passed to normalizeRoundAndPackFloat128() as high > first, low second. The current code passes the integer first, so the > result is incorrectly shifted left by 64 bits. > > This bug affects the emulation of s390x instruction CXLGBR

Re: [Qemu-devel] [PATCH 1/1] Fix conversion from uint64 to float128

2018-05-11 Thread Petr Tesarik
On Fri, 11 May 2018 09:10:52 +0200 Petr Tesarik wrote: > The significand is passed to normalizeRoundAndPackFloat128() as high > first, low second. The current code passes the integer first, so the > result is incorrectly shifted left by 64 bits. > > This bug affects the emulation of s390x instru

[Qemu-devel] [PATCH 1/1] Fix conversion from uint64 to float128

2018-05-11 Thread Petr Tesarik
The significand is passed to normalizeRoundAndPackFloat128() as high first, low second. The current code passes the integer first, so the result is incorrectly shifted left by 64 bits. This bug affects the emulation of s390x instruction CXLGBR (convert from logical 64-bit binary-integer operand to