Re: [Qemu-devel] [PATCH 1/1] Allocating Large sized arrays to heap

2016-03-14 Thread Paolo Bonzini
The subject isn't very clear, because it doesn't say which subsystem is being modified. You should use something like virtio: allocate temporary VirtQueueElementOld on heap The rest of the commit message is okay, but the lines are a bit long. Usually we use 70-75 characters only. On 11/03/2016

[Qemu-devel] [PATCH 1/1] Allocating Large sized arrays to heap

2016-03-11 Thread Jaya Tiwari
As per the list of functions in http://wiki.qemu.org/BiteSizedTasks#Large_frames, qemu_get_virtqueue_element and qemu_put_virtqueue_element have large arrays on stack Hence, moving them to heap. This reduced their stack size from something 49248 to fit into less than 200 Signed-off-by: Jaya Ti