Re: [Qemu-devel] [PATCH 09/22] exec-all: shrink tb->invalid to uint8_t

2017-07-16 Thread Richard Henderson
On 07/15/2017 03:43 PM, Emilio G. Cota wrote: On Wed, Jul 12, 2017 at 13:06:23 -1000, Richard Henderson wrote: You've got a problem here in that you're not including CF_COUNT_MASK in the hash and you dropped the flush when changing to parallel_cpus = true. That means you could find an old TB wi

Re: [Qemu-devel] [PATCH 09/22] exec-all: shrink tb->invalid to uint8_t

2017-07-15 Thread Emilio G. Cota
On Wed, Jul 12, 2017 at 13:06:23 -1000, Richard Henderson wrote: > You've got a problem here in that you're not including CF_COUNT_MASK in the > hash and you dropped the flush when changing to parallel_cpus = true. That > means you could find an old TB with CF_COUNT > 1. > > Not required for this

Re: [Qemu-devel] [PATCH 09/22] exec-all: shrink tb->invalid to uint8_t

2017-07-12 Thread Richard Henderson
On 07/12/2017 10:48 AM, Emilio G. Cota wrote: Would it be OK for this series to just start with CF_PARALLEL? I'm not too familiar with how icount mode recompiles code, and I'm now on patch 27 of v2 and still have quite a few patches to go through. Certainly. diff --git a/accel/tcg/cpu-exec.c

Re: [Qemu-devel] [PATCH 09/22] exec-all: shrink tb->invalid to uint8_t

2017-07-12 Thread Emilio G. Cota
On Tue, Jul 11, 2017 at 14:53:00 -1000, Richard Henderson wrote: > On 07/10/2017 01:57 PM, Emilio G. Cota wrote: > >>What I would prefer to do is generalize tb->cflags. Those values *do* > >>affect how we compile the TB, and yet we don't take them into account. So I > >>think it would be a good i

Re: [Qemu-devel] [PATCH 09/22] exec-all: shrink tb->invalid to uint8_t

2017-07-11 Thread Richard Henderson
On 07/10/2017 01:57 PM, Emilio G. Cota wrote: What I would prefer to do is generalize tb->cflags. Those values *do* affect how we compile the TB, and yet we don't take them into account. So I think it would be a good idea to feed that into the TB hash. I'm having trouble seeing how this could

Re: [Qemu-devel] [PATCH 09/22] exec-all: shrink tb->invalid to uint8_t

2017-07-10 Thread Emilio G. Cota
On Sun, Jul 09, 2017 at 10:11:21 -1000, Richard Henderson wrote: > On 07/08/2017 09:50 PM, Emilio G. Cota wrote: > >To avoid wasting a byte. I don't have any use in mind for this byte, > >but I think it's good to leave this byte explicitly free for future use. > >See this discussion for how the u16

Re: [Qemu-devel] [PATCH 09/22] exec-all: shrink tb->invalid to uint8_t

2017-07-09 Thread Richard Henderson
On 07/08/2017 09:50 PM, Emilio G. Cota wrote: To avoid wasting a byte. I don't have any use in mind for this byte, but I think it's good to leave this byte explicitly free for future use. See this discussion for how the u16 came to be: https://lists.gnu.org/archive/html/qemu-devel/2016-07/msg0

[Qemu-devel] [PATCH 09/22] exec-all: shrink tb->invalid to uint8_t

2017-07-09 Thread Emilio G. Cota
To avoid wasting a byte. I don't have any use in mind for this byte, but I think it's good to leave this byte explicitly free for future use. See this discussion for how the u16 came to be: https://lists.gnu.org/archive/html/qemu-devel/2016-07/msg04564.html We could use a bool but in some systems