Re: [Qemu-devel] [PATCH 09/14] ppc: introduce ppc_get_crf and ppc_set_crf

2014-09-19 Thread Paolo Bonzini
Il 18/09/2014 21:51, Tom Musta ha scritto: > > Checkpatch fails: > WARNING: braces {} are necessary for all arms of this statement > #171: FILE: target-ppc/translate.c:1: > +if (ppc_get_crf(env, i) & 0x08) > [...] > -else if (env->crf[i] & 0x04) > [...] > a = 'G';

Re: [Qemu-devel] [PATCH 09/14] ppc: introduce ppc_get_crf and ppc_set_crf

2014-09-18 Thread Tom Musta
On 9/15/2014 10:03 AM, Paolo Bonzini wrote: > These two functions will group together four CR bits into a single > value, once we change the representation of condition registers. > > Signed-off-by: Paolo Bonzini > --- > linux-user/main.c| 2 +- > target-ppc/cpu.h | 10 +

[Qemu-devel] [PATCH 09/14] ppc: introduce ppc_get_crf and ppc_set_crf

2014-09-15 Thread Paolo Bonzini
These two functions will group together four CR bits into a single value, once we change the representation of condition registers. Signed-off-by: Paolo Bonzini --- linux-user/main.c| 2 +- target-ppc/cpu.h | 10 ++ target-ppc/excp_helper.c | 2 +- target-ppc/fpu_helper