Re: [Qemu-devel] [PATCH 09/11] pci: add trace-events support for hw/pci-host

2018-01-15 Thread Michael S. Tsirkin
On Sun, Jan 14, 2018 at 10:47:49AM +, Mark Cave-Ayland wrote: > Signed-off-by: Mark Cave-Ayland > CC: Michael S. Tsirkin > CC: Marcel Apfelbaum Seems harmless so why not. Acked-by: Michael S. Tsirkin > --- > Makefile.objs| 1 + > hw/pci-host/trace-events | 1 + > 2 files c

Re: [Qemu-devel] [PATCH 09/11] pci: add trace-events support for hw/pci-host

2018-01-15 Thread Mark Cave-Ayland
On 14/01/18 16:27, Marcel Apfelbaum wrote: On 14/01/2018 15:32, Philippe Mathieu-Daudé wrote: On 01/14/2018 07:47 AM, Mark Cave-Ayland wrote: Signed-off-by: Mark Cave-Ayland Not sure this is worth a separate commit (I'd squash it in the next patch), still: I agree, no need to add a new dir

Re: [Qemu-devel] [PATCH 09/11] pci: add trace-events support for hw/pci-host

2018-01-14 Thread Marcel Apfelbaum
On 14/01/2018 15:32, Philippe Mathieu-Daudé wrote: On 01/14/2018 07:47 AM, Mark Cave-Ayland wrote: Signed-off-by: Mark Cave-Ayland Not sure this is worth a separate commit (I'd squash it in the next patch), still: I agree, no need to add a new directory to the trace list while we don't have

Re: [Qemu-devel] [PATCH 09/11] pci: add trace-events support for hw/pci-host

2018-01-14 Thread Philippe Mathieu-Daudé
On 01/14/2018 07:47 AM, Mark Cave-Ayland wrote: > Signed-off-by: Mark Cave-Ayland Not sure this is worth a separate commit (I'd squash it in the next patch), still: Reviewed-by: Philippe Mathieu-Daudé > CC: Michael S. Tsirkin > CC: Marcel Apfelbaum > --- > Makefile.objs| 1 + > h

[Qemu-devel] [PATCH 09/11] pci: add trace-events support for hw/pci-host

2018-01-14 Thread Mark Cave-Ayland
Signed-off-by: Mark Cave-Ayland CC: Michael S. Tsirkin CC: Marcel Apfelbaum --- Makefile.objs| 1 + hw/pci-host/trace-events | 1 + 2 files changed, 2 insertions(+) create mode 100644 hw/pci-host/trace-events diff --git a/Makefile.objs b/Makefile.objs index c8b1bba593..6aa793ce4f