[Qemu-devel] [PATCH 09/10] tcp_close(): check for close() errors too (v2)

2011-11-10 Thread Eduardo Habkost
In case close() fails, we want to report the error back. Changes v1 -> v2: - Use braces on if statement to match coding style Signed-off-by: Eduardo Habkost --- migration-tcp.c |7 +-- 1 files changed, 5 insertions(+), 2 deletions(-) diff --git a/migration-tcp.c b/migration-tcp.c inde

Re: [Qemu-devel] [PATCH 09/10] tcp_close(): check for close() errors too

2011-11-10 Thread Eduardo Habkost
On Thu, Nov 10, 2011 at 04:21:46PM +0800, Dong Xu Wang wrote: > >     if (s->fd != -1) { > > -        close(s->fd); > > +        if (close(s->fd) < 0) > > +            r = -errno; > Braces {} are necessary, or checkpatch.pl will give warnings, also in > other patches in your series. > > No mistake

Re: [Qemu-devel] [PATCH 09/10] tcp_close(): check for close() errors too

2011-11-10 Thread Dong Xu Wang
2011/11/10 Eduardo Habkost : > In case close() fails, we want to report the error back. > > Signed-off-by: Eduardo Habkost > --- >  migration-tcp.c |    6 -- >  1 files changed, 4 insertions(+), 2 deletions(-) > > diff --git a/migration-tcp.c b/migration-tcp.c > index 5aa742c..fd5fd56 100644 >

[Qemu-devel] [PATCH 09/10] tcp_close(): check for close() errors too

2011-11-09 Thread Eduardo Habkost
In case close() fails, we want to report the error back. Signed-off-by: Eduardo Habkost --- migration-tcp.c |6 -- 1 files changed, 4 insertions(+), 2 deletions(-) diff --git a/migration-tcp.c b/migration-tcp.c index 5aa742c..fd5fd56 100644 --- a/migration-tcp.c +++ b/migration-tcp.c @@