Re: [Qemu-devel] [PATCH 09/10] scsi: add multipath support to qemu-pr-helper

2017-08-30 Thread Stefan Hajnoczi
On Tue, Aug 22, 2017 at 03:18:31PM +0200, Paolo Bonzini wrote: > +static int multipath_pr_in(int fd, const uint8_t *cdb, uint8_t *sense, > + uint8_t *data, int sz) > +{ > +int rq_servact = cdb[1]; > +struct prin_resp resp; > +size_t written; > +int r; > + >

Re: [Qemu-devel] [PATCH 09/10] scsi: add multipath support to qemu-pr-helper

2017-08-30 Thread Stefan Hajnoczi
On Tue, Aug 22, 2017 at 03:18:31PM +0200, Paolo Bonzini wrote: > @@ -444,6 +740,11 @@ static int drop_privileges(void) > CAP_SYS_RAWIO) < 0) { > return -1; > } > +/* For /dev/mapper/control ioctls */ > +if (capng_update(CAPNG_ADD, CAPNG_EFFECTIVE | CAPNG_

Re: [Qemu-devel] [PATCH 09/10] scsi: add multipath support to qemu-pr-helper

2017-08-22 Thread Paolo Bonzini
On 23/08/2017 07:01, Fam Zheng wrote: > On Tue, 08/22 15:18, Paolo Bonzini wrote: >> Proper support of persistent reservation for multipath devices requires >> communication with the multipath daemon, so that the reservation is >> registered and applied when a path comes up. The device mapper >> u

Re: [Qemu-devel] [PATCH 09/10] scsi: add multipath support to qemu-pr-helper

2017-08-22 Thread Fam Zheng
On Tue, 08/22 15:18, Paolo Bonzini wrote: > Proper support of persistent reservation for multipath devices requires > communication with the multipath daemon, so that the reservation is > registered and applied when a path comes up. The device mapper > utilities provide a library to do so; this pa

[Qemu-devel] [PATCH 09/10] scsi: add multipath support to qemu-pr-helper

2017-08-22 Thread Paolo Bonzini
Proper support of persistent reservation for multipath devices requires communication with the multipath daemon, so that the reservation is registered and applied when a path comes up. The device mapper utilities provide a library to do so; this patch makes qemu-pr-helper.c detect multipath device