Re: [Qemu-devel] [PATCH 08/14] qapi: convert eject (qmp and hmp) to QAPI

2011-09-02 Thread Kevin Wolf
Am 02.09.2011 18:05, schrieb Anthony Liguori: > On 08/25/2011 08:52 AM, Kevin Wolf wrote: >> Am 25.08.2011 15:40, schrieb Anthony Liguori: >>> On 08/25/2011 07:19 AM, Kevin Wolf wrote: Am 24.08.2011 20:43, schrieb Anthony Liguori: > Signed-off-by: Anthony Liguori > --- >blockde

Re: [Qemu-devel] [PATCH 08/14] qapi: convert eject (qmp and hmp) to QAPI

2011-09-02 Thread Anthony Liguori
On 08/25/2011 08:52 AM, Kevin Wolf wrote: Am 25.08.2011 15:40, schrieb Anthony Liguori: On 08/25/2011 07:19 AM, Kevin Wolf wrote: Am 24.08.2011 20:43, schrieb Anthony Liguori: Signed-off-by: Anthony Liguori --- blockdev.c | 22 +++--- blockdev.h |1 - h

Re: [Qemu-devel] [PATCH 08/14] qapi: convert eject (qmp and hmp) to QAPI

2011-08-25 Thread Avi Kivity
On 08/25/2011 04:52 PM, Kevin Wolf wrote: > > It's not pretty, but it lets us preserve compatibility. I think it's > also safer for dealing with pointers because otherwise you have a mix of > pointers that may be null and may not be null. Having a clear > indication of which pointers are nu

Re: [Qemu-devel] [PATCH 08/14] qapi: convert eject (qmp and hmp) to QAPI

2011-08-25 Thread Kevin Wolf
Am 25.08.2011 15:40, schrieb Anthony Liguori: > On 08/25/2011 07:19 AM, Kevin Wolf wrote: >> Am 24.08.2011 20:43, schrieb Anthony Liguori: >>> Signed-off-by: Anthony Liguori >>> --- >>> blockdev.c | 22 +++--- >>> blockdev.h |1 - >>> hmp-commands.hx |3 +-

Re: [Qemu-devel] [PATCH 08/14] qapi: convert eject (qmp and hmp) to QAPI

2011-08-25 Thread Anthony Liguori
On 08/25/2011 07:19 AM, Kevin Wolf wrote: Am 24.08.2011 20:43, schrieb Anthony Liguori: Signed-off-by: Anthony Liguori --- blockdev.c | 22 +++--- blockdev.h |1 - hmp-commands.hx |3 +-- hmp.c| 14 ++ hmp.h|1

Re: [Qemu-devel] [PATCH 08/14] qapi: convert eject (qmp and hmp) to QAPI

2011-08-25 Thread Kevin Wolf
Am 24.08.2011 20:43, schrieb Anthony Liguori: > Signed-off-by: Anthony Liguori > --- > blockdev.c | 22 +++--- > blockdev.h |1 - > hmp-commands.hx |3 +-- > hmp.c| 14 ++ > hmp.h|1 + > qapi-schema.json | 25 +

Re: [Qemu-devel] [PATCH 08/14] qapi: convert eject (qmp and hmp) to QAPI

2011-08-24 Thread Luiz Capitulino
On Wed, 24 Aug 2011 13:43:03 -0500 Anthony Liguori wrote: > Signed-off-by: Anthony Liguori > --- > blockdev.c | 22 +++--- > blockdev.h |1 - > hmp-commands.hx |3 +-- > hmp.c| 14 ++ > hmp.h|1 + > qapi-schema.jso

[Qemu-devel] [PATCH 08/14] qapi: convert eject (qmp and hmp) to QAPI

2011-08-24 Thread Anthony Liguori
Signed-off-by: Anthony Liguori --- blockdev.c | 22 +++--- blockdev.h |1 - hmp-commands.hx |3 +-- hmp.c| 14 ++ hmp.h|1 + qapi-schema.json | 25 + qmp-commands.hx |3 +-- 7 files cha