On 01/20/2016 01:07 AM, Fam Zheng wrote:
> On Thu, 01/07 14:30, John Snow wrote:
>>> +void bdrv_release_meta_dirty_bitmap(BdrvDirtyBitmap *bitmap)
>>> +{
>>> +assert(bitmap->meta);
>>> +hbitmap_free(bitmap->meta);
>>
>> This leaves a dangling pointer inside the Hbitmap, no?
>
> Yes, will
On Thu, 01/07 14:30, John Snow wrote:
> > +void bdrv_release_meta_dirty_bitmap(BdrvDirtyBitmap *bitmap)
> > +{
> > +assert(bitmap->meta);
> > +hbitmap_free(bitmap->meta);
>
> This leaves a dangling pointer inside the Hbitmap, no?
Yes, will fix.
>
> > +bitmap->meta = NULL;
> > +}
> >
On 01/04/2016 05:27 AM, Fam Zheng wrote:
> The added group of operations enables tracking of the changed bits in
> the dirty bitmap.
>
> Signed-off-by: Fam Zheng
> ---
> block/dirty-bitmap.c | 51
>
> include/block/dirty-bitmap.h | 9 +
The added group of operations enables tracking of the changed bits in
the dirty bitmap.
Signed-off-by: Fam Zheng
---
block/dirty-bitmap.c | 51
include/block/dirty-bitmap.h | 9
2 files changed, 60 insertions(+)
diff --git a/block/d