Re: [Qemu-devel] [PATCH 07/18] migration: make writes blocking

2012-10-30 Thread Juan Quintela
Markus Armbruster wrote: > Juan Quintela writes: > > Doesn't this break inet_nonblocking_connect() and > unix_nonblocking_connect()? > > In your cover letter, you wrote: > > Note: Writes has become blocking, and I have to change the "remove" > the feature n

Re: [Qemu-devel] [PATCH 07/18] migration: make writes blocking

2012-10-30 Thread Markus Armbruster
Juan Quintela writes: > Markus Armbruster wrote: >> Juan Quintela writes: >> >>> Markus Armbruster wrote: Juan Quintela writes: > Move all the writes to the migration_thread, and make writings > blocking. Notice that are still using the iothread for everything > that we

Re: [Qemu-devel] [PATCH 07/18] migration: make writes blocking

2012-10-30 Thread Juan Quintela
Markus Armbruster wrote: > Juan Quintela writes: > >> Markus Armbruster wrote: >>> Juan Quintela writes: >>> Move all the writes to the migration_thread, and make writings blocking. Notice that are still using the iothread for everything that we do. >>> [...] diff --git a/q

Re: [Qemu-devel] [PATCH 07/18] migration: make writes blocking

2012-10-30 Thread Markus Armbruster
Juan Quintela writes: > Markus Armbruster wrote: >> Juan Quintela writes: >> >>> Move all the writes to the migration_thread, and make writings >>> blocking. Notice that are still using the iothread for everything >>> that we do. >> [...] >>> diff --git a/qemu-sockets.c b/qemu-sockets.c >>> in

Re: [Qemu-devel] [PATCH 07/18] migration: make writes blocking

2012-10-29 Thread Paolo Bonzini
Il 29/10/2012 18:32, Juan Quintela ha scritto: >> > New users can't "just add socket_set_nonblock()". They'd have to add it >> > right where you deleted it: between qemu_socket() and connect(). Else >> > the connect() is blocking. > Grrr. > > So, is there any way to make a connection that is non

Re: [Qemu-devel] [PATCH 07/18] migration: make writes blocking

2012-10-29 Thread Juan Quintela
Markus Armbruster wrote: > Juan Quintela writes: > >> Move all the writes to the migration_thread, and make writings >> blocking. Notice that are still using the iothread for everything >> that we do. > [...] >> diff --git a/qemu-sockets.c b/qemu-sockets.c >> index cfed9c5..61b6e95 100644 >> ---

Re: [Qemu-devel] [PATCH 07/18] migration: make writes blocking

2012-10-29 Thread Markus Armbruster
Juan Quintela writes: > Move all the writes to the migration_thread, and make writings > blocking. Notice that are still using the iothread for everything > that we do. [...] > diff --git a/qemu-sockets.c b/qemu-sockets.c > index cfed9c5..61b6e95 100644 > --- a/qemu-sockets.c > +++ b/qemu-socket

[Qemu-devel] [PATCH 07/18] migration: make writes blocking

2012-10-29 Thread Juan Quintela
Move all the writes to the migration_thread, and make writings blocking. Notice that are still using the iothread for everything that we do. Signed-off-by: Juan Quintela --- migration-exec.c | 1 - migration-fd.c | 1 - migration.c | 21 - qemu-file.h | 5