Re: [Qemu-devel] [PATCH 07/14] exec.c: Add new address_space_ld*/st* functions

2015-04-09 Thread Paolo Bonzini
On 09/04/2015 14:38, Peter Maydell wrote: > They need to be in memory.h because cpu-all.h doesn't have > all the typedefs. Also, memory.h seems to me clearly the > best place, since it's where we declare the MemoryRegion > and AddressSpace related functions. > > It's certainly true that using ta

Re: [Qemu-devel] [PATCH 07/14] exec.c: Add new address_space_ld*/st* functions

2015-04-09 Thread Peter Maydell
On 9 April 2015 at 13:00, Paolo Bonzini wrote: > > > On 09/04/2015 13:49, Peter Maydell wrote: >>> > I think we do not want to expose these at all (or at least, all users >>> > should really be CPUs and hence use *_phys functions). >>> > >>> > S390 is always big-endian, and watch_mem_read/write ca

Re: [Qemu-devel] [PATCH 07/14] exec.c: Add new address_space_ld*/st* functions

2015-04-09 Thread Paolo Bonzini
On 09/04/2015 13:49, Peter Maydell wrote: >> > I think we do not want to expose these at all (or at least, all users >> > should really be CPUs and hence use *_phys functions). >> > >> > S390 is always big-endian, and watch_mem_read/write can use the same >> > buffer trick as subpages (and in fac

Re: [Qemu-devel] [PATCH 07/14] exec.c: Add new address_space_ld*/st* functions

2015-04-09 Thread Peter Maydell
On 8 April 2015 at 12:03, Paolo Bonzini wrote: > > > On 07/04/2015 22:09, Peter Maydell wrote: >> +#ifdef NEED_CPU_H >> +uint32_t address_space_lduw(AddressSpace *as, hwaddr addr, >> +MemTxAttrs attrs, MemTxResult *result); >> +uint32_t address_space_ldl(AddressSpace *a

Re: [Qemu-devel] [PATCH 07/14] exec.c: Add new address_space_ld*/st* functions

2015-04-09 Thread Edgar E. Iglesias
On Tue, Apr 07, 2015 at 09:09:53PM +0100, Peter Maydell wrote: > Add new address_space_ld*/st* functions which allow transaction > attributes and error reporting for basic load and stores. These > are named to be in line with the address_space_read/write/rw > buffer operations. > > The existing ld

Re: [Qemu-devel] [PATCH 07/14] exec.c: Add new address_space_ld*/st* functions

2015-04-08 Thread Paolo Bonzini
On 07/04/2015 22:09, Peter Maydell wrote: > +#ifdef NEED_CPU_H > +uint32_t address_space_lduw(AddressSpace *as, hwaddr addr, > +MemTxAttrs attrs, MemTxResult *result); > +uint32_t address_space_ldl(AddressSpace *as, hwaddr addr, > +MemTxAttr

[Qemu-devel] [PATCH 07/14] exec.c: Add new address_space_ld*/st* functions

2015-04-07 Thread Peter Maydell
Add new address_space_ld*/st* functions which allow transaction attributes and error reporting for basic load and stores. These are named to be in line with the address_space_read/write/rw buffer operations. The existing ld/st*_phys functions are now wrappers around the new functions. Signed-off-