Re: [Qemu-devel] [PATCH 07/10] serial: fixing vmstate for save/restore

2014-09-10 Thread Pavel Dovgaluk
> From: Paolo Bonzini [mailto:pbonz...@redhat.com] > Il 09/09/2014 15:59, Juan Quintela ha scritto: > > But poll_msl is "more" interesting, because we are not "reseting it". > > > > So, we have that if we are migrating from an old version, we would have > > poll_msl == -1, and we used to have it to

Re: [Qemu-devel] [PATCH 07/10] serial: fixing vmstate for save/restore

2014-09-10 Thread Paolo Bonzini
Il 09/09/2014 14:30, Paolo Bonzini ha scritto: > From: Pavel Dovgalyuk > > Some fields were added to VMState by this patch to preserve correct > loading of the serial port controller state. > Updating FCR value while loading was also modified to disable generating > an interrupt by loadvm. This

Re: [Qemu-devel] [PATCH 07/10] serial: fixing vmstate for save/restore

2014-09-09 Thread Paolo Bonzini
Il 09/09/2014 15:59, Juan Quintela ha scritto: > If it is still -1 at this point, we "calculate" a value for it. > (I assume it is right, no knowledge of serial port) Not necessarily right, or we wouldn't need the subsection, but at least a decent approximation. > But poll_msl is "more" interesti

Re: [Qemu-devel] [PATCH 07/10] serial: fixing vmstate for save/restore

2014-09-09 Thread Juan Quintela
Paolo Bonzini wrote: > From: Pavel Dovgalyuk > > Some fields were added to VMState by this patch to preserve correct > loading of the serial port controller state. > Updating FCR value while loading was also modified to disable generating > an interrupt by loadvm. > > Signed-off-by: Pavel Dovgaly

[Qemu-devel] [PATCH 07/10] serial: fixing vmstate for save/restore

2014-09-09 Thread Paolo Bonzini
From: Pavel Dovgalyuk Some fields were added to VMState by this patch to preserve correct loading of the serial port controller state. Updating FCR value while loading was also modified to disable generating an interrupt by loadvm. Signed-off-by: Pavel Dovgalyuk Signed-off-by: Paolo Bonzini --