Re: [Qemu-devel] [PATCH 07/10] block/backup: support block job transactions

2015-07-01 Thread Stefan Hajnoczi
On Tue, Jun 30, 2015 at 11:52:54AM -0400, John Snow wrote: > On 06/30/2015 11:27 AM, Stefan Hajnoczi wrote: > > On Mon, Jun 29, 2015 at 06:39:08PM -0400, John Snow wrote: > >> On 06/25/2015 08:12 AM, Stefan Hajnoczi wrote: > >>> @@ -537,6 +539,9 @@ void backup_start(BlockDriverState *bs, > >>> Blo

Re: [Qemu-devel] [PATCH 07/10] block/backup: support block job transactions

2015-06-30 Thread John Snow
On 06/30/2015 11:27 AM, Stefan Hajnoczi wrote: > On Mon, Jun 29, 2015 at 06:39:08PM -0400, John Snow wrote: >> >> >> On 06/25/2015 08:12 AM, Stefan Hajnoczi wrote: >>> Join the transaction when the backup block job is in incremental backup >>> mode. >>> >>> This ensures that the sync bitmap is no

Re: [Qemu-devel] [PATCH 07/10] block/backup: support block job transactions

2015-06-30 Thread Stefan Hajnoczi
On Mon, Jun 29, 2015 at 06:39:08PM -0400, John Snow wrote: > > > On 06/25/2015 08:12 AM, Stefan Hajnoczi wrote: > > Join the transaction when the backup block job is in incremental backup > > mode. > > > > This ensures that the sync bitmap is not thrown away if another block > > job in the trans

Re: [Qemu-devel] [PATCH 07/10] block/backup: support block job transactions

2015-06-29 Thread John Snow
On 06/25/2015 08:12 AM, Stefan Hajnoczi wrote: > Join the transaction when the backup block job is in incremental backup > mode. > > This ensures that the sync bitmap is not thrown away if another block > job in the transaction is cancelled or fails. This is critical so > incremental backup wit

Re: [Qemu-devel] [PATCH 07/10] block/backup: support block job transactions

2015-06-25 Thread Fam Zheng
On Thu, 06/25 13:12, Stefan Hajnoczi wrote: > Join the transaction when the backup block job is in incremental backup > mode. > > This ensures that the sync bitmap is not thrown away if another block > job in the transaction is cancelled or fails. This is critical so > incremental backup with mul

[Qemu-devel] [PATCH 07/10] block/backup: support block job transactions

2015-06-25 Thread Stefan Hajnoczi
Join the transaction when the backup block job is in incremental backup mode. This ensures that the sync bitmap is not thrown away if another block job in the transaction is cancelled or fails. This is critical so incremental backup with multiple disks can be retried in case of cancellation/failu