Re: [Qemu-devel] [PATCH 06/21] qmp: Drop duplicated QMP command object checks

2017-02-24 Thread Markus Armbruster
Eric Blake writes: > On 02/23/2017 03:45 PM, Markus Armbruster wrote: >> qmp_check_input_obj() duplicates qmp_dispatch_check_obj(), except the >> latter screws up an error message. handle_qmp_command() runs first >> the former, then the latter via qmp_dispatch(), masking the screwup. >> >> qemu

Re: [Qemu-devel] [PATCH 06/21] qmp: Drop duplicated QMP command object checks

2017-02-24 Thread Eric Blake
On 02/23/2017 03:45 PM, Markus Armbruster wrote: > qmp_check_input_obj() duplicates qmp_dispatch_check_obj(), except the > latter screws up an error message. handle_qmp_command() runs first > the former, then the latter via qmp_dispatch(), masking the screwup. > > qemu-ga also masks the screwup,

[Qemu-devel] [PATCH 06/21] qmp: Drop duplicated QMP command object checks

2017-02-23 Thread Markus Armbruster
qmp_check_input_obj() duplicates qmp_dispatch_check_obj(), except the latter screws up an error message. handle_qmp_command() runs first the former, then the latter via qmp_dispatch(), masking the screwup. qemu-ga also masks the screwup, because it also duplicates checks, just differently. qmp_c