Re: [Qemu-devel] [PATCH 06/21] qcow2: Helper function for refcount modification

2014-11-11 Thread Max Reitz
On 2014-11-11 at 09:35, Max Reitz wrote: On 2014-11-10 at 23:30, Eric Blake wrote: On 11/10/2014 06:45 AM, Max Reitz wrote: Since refcounts do not always have to be a uint16_t, all refcount blocks and arrays in memory should not have a specific type (thus they become pointers to void) and for

Re: [Qemu-devel] [PATCH 06/21] qcow2: Helper function for refcount modification

2014-11-11 Thread Max Reitz
On 2014-11-11 at 09:35, Max Reitz wrote: On 2014-11-10 at 23:30, Eric Blake wrote: On 11/10/2014 06:45 AM, Max Reitz wrote: Since refcounts do not always have to be a uint16_t, all refcount blocks and arrays in memory should not have a specific type (thus they become pointers to void) and for

Re: [Qemu-devel] [PATCH 06/21] qcow2: Helper function for refcount modification

2014-11-11 Thread Max Reitz
On 2014-11-10 at 23:30, Eric Blake wrote: On 11/10/2014 06:45 AM, Max Reitz wrote: Since refcounts do not always have to be a uint16_t, all refcount blocks and arrays in memory should not have a specific type (thus they become pointers to void) and for accessing them, two helper functions are us

Re: [Qemu-devel] [PATCH 06/21] qcow2: Helper function for refcount modification

2014-11-10 Thread Eric Blake
On 11/10/2014 06:45 AM, Max Reitz wrote: > Since refcounts do not always have to be a uint16_t, all refcount blocks > and arrays in memory should not have a specific type (thus they become > pointers to void) and for accessing them, two helper functions are used > (a getter and a setter). Those fun

[Qemu-devel] [PATCH 06/21] qcow2: Helper function for refcount modification

2014-11-10 Thread Max Reitz
Since refcounts do not always have to be a uint16_t, all refcount blocks and arrays in memory should not have a specific type (thus they become pointers to void) and for accessing them, two helper functions are used (a getter and a setter). Those functions are called indirectly through function poi