Re: [Qemu-devel] [PATCH 06/17] qsp: Simplify how qsp_report() prints

2019-04-12 Thread Dr. David Alan Gilbert
* Markus Armbruster (arm...@redhat.com) wrote: > qsp_report() takes an fprintf()-like callback and a FILE * to pass to > it. > > Its only caller hmp_sync_profile() passes monitor_fprintf() and the > current monitor cast to FILE *. monitor_fprintf() casts it right > back, and is otherwise identica

[Qemu-devel] [PATCH 06/17] qsp: Simplify how qsp_report() prints

2019-04-11 Thread Markus Armbruster
qsp_report() takes an fprintf()-like callback and a FILE * to pass to it. Its only caller hmp_sync_profile() passes monitor_fprintf() and the current monitor cast to FILE *. monitor_fprintf() casts it right back, and is otherwise identical to monitor_printf(). The type-punning is ugly. Drop the