Re: [Qemu-devel] [PATCH 06/13] pci: Add INTx routing notifier

2012-06-10 Thread Michael S. Tsirkin
On Sun, Jun 10, 2012 at 02:47:40PM +0200, Jan Kiszka wrote: > On 2012-06-10 14:42, Michael S. Tsirkin wrote: > > On Sun, Jun 10, 2012 at 02:33:03PM +0200, Jan Kiszka wrote: > >> On 2012-06-10 14:16, Michael S. Tsirkin wrote: > >>> On Sun, Jun 10, 2012 at 02:09:20PM +0200, Jan Kiszka wrote: > O

Re: [Qemu-devel] [PATCH 06/13] pci: Add INTx routing notifier

2012-06-10 Thread Jan Kiszka
On 2012-06-10 14:42, Michael S. Tsirkin wrote: > On Sun, Jun 10, 2012 at 02:33:03PM +0200, Jan Kiszka wrote: >> On 2012-06-10 14:16, Michael S. Tsirkin wrote: >>> On Sun, Jun 10, 2012 at 02:09:20PM +0200, Jan Kiszka wrote: On 2012-06-10 13:39, Michael S. Tsirkin wrote: > It's OK to use rec

Re: [Qemu-devel] [PATCH 06/13] pci: Add INTx routing notifier

2012-06-10 Thread Michael S. Tsirkin
On Sun, Jun 10, 2012 at 02:33:03PM +0200, Jan Kiszka wrote: > On 2012-06-10 14:16, Michael S. Tsirkin wrote: > > On Sun, Jun 10, 2012 at 02:09:20PM +0200, Jan Kiszka wrote: > >> On 2012-06-10 13:39, Michael S. Tsirkin wrote: > >>> It's OK to use recursion but when done through a callback > >>> like

Re: [Qemu-devel] [PATCH 06/13] pci: Add INTx routing notifier

2012-06-10 Thread Jan Kiszka
On 2012-06-10 14:16, Michael S. Tsirkin wrote: > On Sun, Jun 10, 2012 at 02:09:20PM +0200, Jan Kiszka wrote: >> On 2012-06-10 13:39, Michael S. Tsirkin wrote: >>> It's OK to use recursion but when done through a callback >>> like this it's unreadable. >> >> Isn't the alternative poking into foreign

Re: [Qemu-devel] [PATCH 06/13] pci: Add INTx routing notifier

2012-06-10 Thread Michael S. Tsirkin
On Sun, Jun 10, 2012 at 01:18:15PM +0200, Jan Kiszka wrote: > >> @@ -318,6 +322,9 @@ PCIBus *pci_register_bus(DeviceState *parent, > >> const char *name, > >> MemoryRegion *address_space_io, > >> uint8_t devfn_min, int nirq); > >>

Re: [Qemu-devel] [PATCH 06/13] pci: Add INTx routing notifier

2012-06-10 Thread Michael S. Tsirkin
On Sun, Jun 10, 2012 at 02:09:20PM +0200, Jan Kiszka wrote: > On 2012-06-10 13:39, Michael S. Tsirkin wrote: > > It's OK to use recursion but when done through a callback > > like this it's unreadable. > > Isn't the alternative poking into foreign bridge device states for their > secondary buses?

Re: [Qemu-devel] [PATCH 06/13] pci: Add INTx routing notifier

2012-06-10 Thread Jan Kiszka
On 2012-06-10 13:39, Michael S. Tsirkin wrote: > It's OK to use recursion but when done through a callback > like this it's unreadable. Isn't the alternative poking into foreign bridge device states for their secondary buses? > Also, you need to setup you cache after intx cache has been > initial

Re: [Qemu-devel] [PATCH 06/13] pci: Add INTx routing notifier

2012-06-10 Thread Michael S. Tsirkin
On Sun, Jun 10, 2012 at 01:18:15PM +0200, Jan Kiszka wrote: > On 2012-06-10 13:11, Michael S. Tsirkin wrote: > > From commit log it would seem that even irq changes should > > invoke this. So why isn't this notifier at the host bridge then? > > Can't follow, where does the commit

Re: [Qemu-devel] [PATCH 06/13] pci: Add INTx routing notifier

2012-06-10 Thread Jan Kiszka
On 2012-06-10 13:11, Michael S. Tsirkin wrote: > From commit log it would seem that even irq changes should > invoke this. So why isn't this notifier at the host bridge then? Can't follow, where does the commit log imply this? It is only about routing changes, not IRQ level c

Re: [Qemu-devel] [PATCH 06/13] pci: Add INTx routing notifier

2012-06-10 Thread Michael S. Tsirkin
On Sun, Jun 10, 2012 at 12:44:05PM +0200, Jan Kiszka wrote: > On 2012-06-10 12:33, Michael S. Tsirkin wrote: > > On Sun, Jun 10, 2012 at 12:05:10PM +0200, Jan Kiszka wrote: > >> On 2012-06-10 11:48, Michael S. Tsirkin wrote: > >>> On Mon, Jun 04, 2012 at 10:52:14AM +0200, Jan Kiszka wrote: > T

Re: [Qemu-devel] [PATCH 06/13] pci: Add INTx routing notifier

2012-06-10 Thread Jan Kiszka
On 2012-06-10 12:33, Michael S. Tsirkin wrote: > On Sun, Jun 10, 2012 at 12:05:10PM +0200, Jan Kiszka wrote: >> On 2012-06-10 11:48, Michael S. Tsirkin wrote: >>> On Mon, Jun 04, 2012 at 10:52:14AM +0200, Jan Kiszka wrote: This per-device notifier shall be triggered by any interrupt router >>>

Re: [Qemu-devel] [PATCH 06/13] pci: Add INTx routing notifier

2012-06-10 Thread Michael S. Tsirkin
On Sun, Jun 10, 2012 at 12:05:10PM +0200, Jan Kiszka wrote: > On 2012-06-10 11:48, Michael S. Tsirkin wrote: > > On Mon, Jun 04, 2012 at 10:52:14AM +0200, Jan Kiszka wrote: > >> This per-device notifier shall be triggered by any interrupt router > >> along the path of a device's legacy interrupt si

Re: [Qemu-devel] [PATCH 06/13] pci: Add INTx routing notifier

2012-06-10 Thread Jan Kiszka
On 2012-06-10 11:48, Michael S. Tsirkin wrote: > On Mon, Jun 04, 2012 at 10:52:14AM +0200, Jan Kiszka wrote: >> This per-device notifier shall be triggered by any interrupt router >> along the path of a device's legacy interrupt signal on routing changes. >> For simplicity reasons and as this is a

Re: [Qemu-devel] [PATCH 06/13] pci: Add INTx routing notifier

2012-06-10 Thread Michael S. Tsirkin
On Mon, Jun 04, 2012 at 10:52:14AM +0200, Jan Kiszka wrote: > This per-device notifier shall be triggered by any interrupt router > along the path of a device's legacy interrupt signal on routing changes. > For simplicity reasons and as this is a slow path anyway, no further > details on the routin

Re: [Qemu-devel] [PATCH 06/13] pci: Add INTx routing notifier

2012-06-07 Thread Jan Kiszka
On 2012-06-07 15:14, Michael S. Tsirkin wrote: > On Mon, Jun 04, 2012 at 10:52:14AM +0200, Jan Kiszka wrote: >> This per-device notifier shall be triggered by any interrupt router >> along the path of a device's legacy interrupt signal on routing changes. >> For simplicity reasons and as this is a

Re: [Qemu-devel] [PATCH 06/13] pci: Add INTx routing notifier

2012-06-07 Thread Michael S. Tsirkin
On Mon, Jun 04, 2012 at 10:52:14AM +0200, Jan Kiszka wrote: > This per-device notifier shall be triggered by any interrupt router > along the path of a device's legacy interrupt signal on routing changes. > For simplicity reasons and as this is a slow path anyway, no further > details on the routin

[Qemu-devel] [PATCH 06/13] pci: Add INTx routing notifier

2012-06-04 Thread Jan Kiszka
This per-device notifier shall be triggered by any interrupt router along the path of a device's legacy interrupt signal on routing changes. For simplicity reasons and as this is a slow path anyway, no further details on the routing changes are provided. Instead, the callback is expected to use pci