Mike, I got a bug fix for you to consider for 3.0.
Marc-André, there's one remark for you inline.
Marc-André Lureau writes:
> Hi
>
> On Tue, Jul 17, 2018 at 7:53 AM, Markus Armbruster wrote:
>> Marc-André Lureau writes:
>>
>>> json_parser_parse_err() may return something else than a QDict, in
Hi
On Tue, Jul 17, 2018 at 7:53 AM, Markus Armbruster wrote:
> Marc-André Lureau writes:
>
>> json_parser_parse_err() may return something else than a QDict, in
>> which case we loose the object. Let's keep track of the original
>> object to avoid leaks.
>
> Should this leak fix go into 3.0?
It
Marc-André Lureau writes:
> json_parser_parse_err() may return something else than a QDict, in
> which case we loose the object. Let's keep track of the original
> object to avoid leaks.
Should this leak fix go into 3.0?
> When an error occurs, "qdict" contains the response, but we still
> chec
json_parser_parse_err() may return something else than a QDict, in
which case we loose the object. Let's keep track of the original
object to avoid leaks.
When an error occurs, "qdict" contains the response, but we still
check the "execute" key there. Untangle a bit this code, by having a
clear er
