Re: [Qemu-devel] [PATCH 06/11] qmp.py: Couple of pylint/style fixes

2017-07-24 Thread Philippe Mathieu-Daudé
On Tue, Jul 25, 2017 at 3:13 AM, Lukáš Doktor wrote: > Dne 25.7.2017 v 08:04 Philippe Mathieu-Daudé napsal(a): >> Hi Lukáš, >> >> On 07/24/2017 09:36 AM, Lukáš Doktor wrote: >>> Dne 22.7.2017 v 03:30 Philippe Mathieu-Daudé napsal(a): Hi Lukáš, Since comment/indent fixes and code cha

Re: [Qemu-devel] [PATCH 06/11] qmp.py: Couple of pylint/style fixes

2017-07-24 Thread Lukáš Doktor
Dne 25.7.2017 v 08:04 Philippe Mathieu-Daudé napsal(a): > Hi Lukáš, > > On 07/24/2017 09:36 AM, Lukáš Doktor wrote: >> Dne 22.7.2017 v 03:30 Philippe Mathieu-Daudé napsal(a): >>> Hi Lukáš, >>> >>> Since comment/indent fixes and code changes are not related I'd rather see >>> this split in at leas

Re: [Qemu-devel] [PATCH 06/11] qmp.py: Couple of pylint/style fixes

2017-07-24 Thread Philippe Mathieu-Daudé
Hi Lukáš, On 07/24/2017 09:36 AM, Lukáš Doktor wrote: Dne 22.7.2017 v 03:30 Philippe Mathieu-Daudé napsal(a): Hi Lukáš, Since comment/indent fixes and code changes are not related I'd rather see this split in at least 2 patches. Hello Philippe, thank you for the review, I'm wondering what c

Re: [Qemu-devel] [PATCH 06/11] qmp.py: Couple of pylint/style fixes

2017-07-24 Thread Lukáš Doktor
Dne 22.7.2017 v 03:30 Philippe Mathieu-Daudé napsal(a): > Hi Lukáš, > > Since comment/indent fixes and code changes are not related I'd rather see > this split in at least 2 patches. > Hello Philippe, thank you for the review, I'm wondering what code changes you have in mind? This is commit sho

Re: [Qemu-devel] [PATCH 06/11] qmp.py: Couple of pylint/style fixes

2017-07-21 Thread Philippe Mathieu-Daudé
Hi Lukáš, Since comment/indent fixes and code changes are not related I'd rather see this split in at least 2 patches. On 07/20/2017 01:28 PM, Lukáš Doktor wrote: No actual code changes, just a few pylint/style fixes and docstring clarifications. Signed-off-by: Lukáš Doktor --- scripts/qm

[Qemu-devel] [PATCH 06/11] qmp.py: Couple of pylint/style fixes

2017-07-20 Thread Lukáš Doktor
No actual code changes, just a few pylint/style fixes and docstring clarifications. Signed-off-by: Lukáš Doktor --- scripts/qmp/qmp.py | 37 - 1 file changed, 24 insertions(+), 13 deletions(-) diff --git a/scripts/qmp/qmp.py b/scripts/qmp/qmp.py index 62d3651