Re: [Qemu-devel] [PATCH 06/10] tcg: code_bitmap is not used by user-mode emulation

2015-08-29 Thread Paolo Bonzini
On 28/08/2015 16:57, Peter Maydell wrote: >> > More #ifdefs are not nice, but this clarifies why its usage is not >> > protected by tb_lock. > Does it? I thought the idea of this series was to add locking > which we needed for adding multi-threading to softmmu, in > which case presumably we need

Re: [Qemu-devel] [PATCH 06/10] tcg: code_bitmap is not used by user-mode emulation

2015-08-28 Thread Peter Maydell
On 12 August 2015 at 17:40, Paolo Bonzini wrote: > More #ifdefs are not nice, but this clarifies why its usage is not > protected by tb_lock. Does it? I thought the idea of this series was to add locking which we needed for adding multi-threading to softmmu, in which case presumably we need to pr

[Qemu-devel] [PATCH 06/10] tcg: code_bitmap is not used by user-mode emulation

2015-08-12 Thread Paolo Bonzini
More #ifdefs are not nice, but this clarifies why its usage is not protected by tb_lock. Signed-off-by: Paolo Bonzini --- translate-all.c | 10 -- 1 file changed, 8 insertions(+), 2 deletions(-) diff --git a/translate-all.c b/translate-all.c index a6bff72..7aa5664 100644 --- a/translate