Re: [Qemu-devel] [PATCH 05/21] qmp: Clean up how we enforce capability negotiation

2017-02-24 Thread Markus Armbruster
Eric Blake writes: > On 02/23/2017 03:45 PM, Markus Armbruster wrote: >> To enforce capability negotiation before normal operation, >> handle_qmp_command() inspects every command before it's handed off to >> qmp_dispatch(). This is a bit of a layering violation, and results in >> duplicated code

Re: [Qemu-devel] [PATCH 05/21] qmp: Clean up how we enforce capability negotiation

2017-02-24 Thread Eric Blake
On 02/23/2017 03:45 PM, Markus Armbruster wrote: > To enforce capability negotiation before normal operation, > handle_qmp_command() inspects every command before it's handed off to > qmp_dispatch(). This is a bit of a layering violation, and results in > duplicated code. > > Before capability ne

[Qemu-devel] [PATCH 05/21] qmp: Clean up how we enforce capability negotiation

2017-02-23 Thread Markus Armbruster
To enforce capability negotiation before normal operation, handle_qmp_command() inspects every command before it's handed off to qmp_dispatch(). This is a bit of a layering violation, and results in duplicated code. Before capability negotiation (!cur_mon->in_command_mode), we fail commands other